Skip to content

Move TestToken.json into build folder #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
K-Ho merged 2 commits into from
Jul 5, 2020
Merged

Move TestToken.json into build folder #173

K-Ho merged 2 commits into from
Jul 5, 2020

Conversation

@K-Ho
Copy link
Contributor

@K-Ho K-Ho commented Jul 2, 2020

Description

We have a contract building into a folder that is not gitignored (see #171 (comment)) - This just moves the compiled contract json into a build folder

Fixes

  • Fixes (no ticket)

Contributing Agreement

karlfloersch
karlfloersch approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@karlfloersch karlfloersch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Though looks like there are conflicts. But after those are resolved LGTM!

@K-Ho K-Ho merged commit e2c6b7c into master Jul 5, 2020
@karlfloersch karlfloersch mentioned this pull request Jul 6, 2020
Merged
1 task
@K-Ho K-Ho deleted the feat/MoveTestTokenBuild branch September 1, 2020 20:32
ClaytonNorthey92 added a commit to hemilabs/optimism that referenced this pull request Dec 9, 2024
@ClaytonNorthey92
Squashed 'heminetwork/' changes from 526787acd..c9dbc5f58
09cd9c1 
c9dbc5f58 Test fix & fmt
fcf735497 ExternalHeaderMode rebase
f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159)
5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186)
1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181)
383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178)
6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177)
9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175)
a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173)
939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174)
9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139)
159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163)
60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169)
fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168)
65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167)
8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162)
67166046b scripts: add release script (ethereum-optimism#164)
eea96059b ci: add labeler action (ethereum-optimism#165)

git-subtree-dir: heminetwork
git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Jan 25, 2025
@blockchaindevsh
UpgradeSoulGasToken.s.sol: get impl correctly (ethereum-optimism#173)
1cf6e8c 
* get impl correctly

* ensure sgt owner is not changed

* add more checks
agusduha pushed a commit that referenced this pull request Mar 20, 2025
@0xiamflux
feat: standard fee vault (#173)
31759f2 
* chore: remove constructor params from FeeVault, L1FeeVault, SequencerFeeVault and BaseFeeVault

* feat: store SequencerFeeVault, L1FeeVault and BaseFeeVault configs in L1Block

* chore: update tests

* chore: match interfaces with implementation, update versions

* docs: update natspec

* test: add complementary tests

* chore: update L2Genesis to use standard fee vaults code

* docs: update natspec for FeeVault.sol

* refactor: update internal var names to comply with style

* refactor: move ConfigType enum in Types library, remove duplicate declarations

* refactor: setConfig and setGasPayingToken

* feat: allow gas paying token config to be retrieved in L1Block::getConfig

* tests: adds tests for Encoding and L1Block

* chore: move fee vaults config into internal function

* refactor: avoid checking for DEPOSITOR account more than once

* refactor: L1Block to use public functions instead of GasPayingToken lib in getConfig

* test: refactor L1Block tests

* refactor: remove unused imports in L2Genesis script

* chore: lock semver

* test: add documentation comment for test "test_setConfig_isDepositor_reverts"

* refactor: add internal _setGasPayingToken to avoid code duplication

* test: refactor L1Block setConfig tests

* chore: version lock

* test: refactor L1Block tests
ClaytonNorthey92 added a commit to hemilabs/optimism that referenced this pull request Apr 4, 2025
@ClaytonNorthey92
Squashed 'heminetwork/' changes from 526787acd..c9dbc5f58
754cb85 
c9dbc5f58 Test fix & fmt
fcf735497 ExternalHeaderMode rebase
f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159)
5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186)
1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181)
383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178)
6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177)
9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175)
a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173)
939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174)
9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139)
159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163)
60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169)
fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168)
65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167)
8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162)
67166046b scripts: add release script (ethereum-optimism#164)
eea96059b ci: add labeler action (ethereum-optimism#165)

git-subtree-dir: heminetwork
git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
ClaytonNorthey92 added a commit to hemilabs/optimism that referenced this pull request Apr 7, 2025
@ClaytonNorthey92
Squashed 'heminetwork/' changes from 526787acd..c9dbc5f58
0f52e37 
c9dbc5f58 Test fix & fmt
fcf735497 ExternalHeaderMode rebase
f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159)
5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186)
1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181)
383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178)
6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177)
9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175)
a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173)
939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174)
9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139)
159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163)
60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169)
fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168)
65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167)
8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162)
67166046b scripts: add release script (ethereum-optimism#164)
eea96059b ci: add labeler action (ethereum-optimism#165)

git-subtree-dir: heminetwork
git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
feat(mpt): TrieNode retrieval (#173)
49abb3e 
Adds a function to the trie node that allows for opening the trie at a
given path. As the trie is opened, intermediate nodes are persisted
within the trie node passed.
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
@Zena-park
[ARS-01C] Repetitive Authorization Role Declarations ethereum-optimis…
9c8fe46 
…m#173 ethereum-optimism#174 ethereum-optimism#175 ethereum-optimism#176
emhane added a commit that referenced this pull request Feb 3, 2026
@meyer9 @emhane
feat: add support for eth_getProof (#257)
d2212d2 
Adds support for `eth_getProof` RPC method. This required reworking the
launch command to still work with an alternative DB provider.

Closes #173

---------

Co-authored-by: Emilia Hane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karlfloersch karlfloersch karlfloersch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@K-Ho @karlfloersch