Adds L2 Batch Creator #175

willmeister · 2020-07-02T21:43:49Z

Description

Adds L2 Batch Creator that creates batches from txs run in L2.

Note: This is distinct from L1 Batch Creator, which will create batches out of Rollup Transactions pulled from L1 tx calldata.

Metadata

Fixes

Fixes # YAS-454

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

…s from getTransaction and getBlock requests and adding test

…ervices

… other future scheduled tasks)

…ckBatchSubmitter into L2NodeService

karlfloersch

Awesome! This LGTM! And it seems very clean as well! Great separation between batch creation, submission, and pulling data from L1/L2 into rdb!

Left a comment on blockBatches vs blockOfBatches lol forgive me but other than that I didn't have much to say. Oh and there's a sanity check test that could be added as well

karlfloersch · 2020-07-06T16:42:35Z

packages/rollup-core/src/app/l2-node-service.ts

   * @inheritDoc
   */
-  public async handleBlockBatches(blockBatches: BlockBatches): Promise<void> {
+  public async sendBlockBatches(blockBatches: BlockBatches): Promise<void> {


I really have struggled to find things to complain about in this PR! Lol everything seems good! That said, I will say that I still do like the name BlockOfBatches here because once again I had to remind myself what this object was

I know we said we'd update it later but figure that because this PR touches them again might be a reasonable time to make the change if it's not super hard?

Yeah, I think a rename is in order since we will no longer be sending all batches for an L1 block together, and each one will be a single batch. This requires a change on the go side as well, so just left it for now.

Created a ticket https://optimists.atlassian.net/browse/YAS-499

karlfloersch · 2020-07-06T16:44:38Z

packages/rollup-core/test/app/l2-batch-creator.spec.ts

+      `1 L1 matching batche should have been attempted!`
+    )
+  })
+})


👍 solid! I guess one thing we could add is a test that actually does produce a batch

Yep! That'll have to be on the submission side of things though, as all this does is stage the batch for submission in the DB.

karlfloersch · 2020-07-06T17:04:23Z

packages/rollup-core/test/app/l2-batch-submitter.spec.ts

+            l1Timestamp: 1,
+            l1BlockNumber: 1,
+            l1TxHash: keccak256FromUtf8('tx hash'),
+            queueOrigin: 1,


* Add nonreentrant to ExecutionManager.run() * Cheaper check using uninit'd tx context * Remove extraneous import

c9dbc5f58 Test fix & fmt fcf735497 ExternalHeaderMode rebase f09d4e5ff Add for wind/unwind support to tbc (ethereum-optimism#159) 5c764a0cd popm: exclude tx outputs that would be dust (ethereum-optimism#186) 1f168f225 popm/wasm: fix dispatch params for {add,remove}EventListener (ethereum-optimism#181) 383611feb popm/wasm: add 'minerStatus' method (ethereum-optimism#178) 6a94b4c0b popm/wasm: rename KeyResult fields and add bitcoinScriptHash (ethereum-optimism#177) 9c4cea583 popm/wasm: add events and clean up globals (ethereum-optimism#175) a2372394d popm: improve UTXO selection when creating Bitcoin transaction (ethereum-optimism#173) 939813cac popm/wasm: fix ethereum address when generating and parsing keys (ethereum-optimism#174) 9245995ef Updated localnet to use more recent commits of optimism and op-geth (ethereum-optimism#139) 159fbc5f5 ci: improve runtime of high usage CI workflows (ethereum-optimism#163) 60a3489db popm/wasm: add 'bitcoinAddressToScriptHash' method (ethereum-optimism#169) fe9752a5a popm/wasm: add 'parseKey' method (ethereum-optimism#168) 65aa0caef ci: add registry-url to setup-node in release (ethereum-optimism#167) 8922ce805 popm/wasm: add new @hemilabs/pop-miner NPM package (ethereum-optimism#162) 67166046b scripts: add release script (ethereum-optimism#164) eea96059b ci: add labeler action (ethereum-optimism#165) git-subtree-dir: heminetwork git-subtree-split: c9dbc5f58a7f997fa4b3af0d765a2967ed3462d1

* binary release for op-node * add a comment * add workflow for op-challenger

…m#173 ethereum-optimism#174 ethereum-optimism#175 ethereum-optimism#176

willmeister added 16 commits June 25, 2020 22:58

adding function to monkey-patch Ethers providers to parse transaction…

820d523

…s from getTransaction and getBlock requests and adding test

adding function to monkey-patch Ethers providers to parse transaction…

c87b00a

…s from getTransaction and getBlock requests and adding test

WIP reworking L1 & L2 subs to populate single DB

1ed38c5

First stab at data persister + SQL backend + polling for downstream s…

c3ebd0f

…ervices

Adding L1 Chain Persister tests

5fb2da7

Adding L1 Chain Data Provider tests

639640e

Adding verifier tests, adding ScheduledTask for polling services (and…

9412add

… other future scheduled tasks)

merging yarn.lock

fb64b2f

fixing lint issues

6d60691

fixing issue in ScheduledTask

c95cddf

Removing batch-item-processor, adding verifier recovery tests

8dcaceb

fixing log statements that would otherwise be too verbose

138a2f8

Adding l2-batch-creator

8db07ab

Updating L2 Batch Submitter to be a data consumer and generifying Blo…

585845f

…ckBatchSubmitter into L2NodeService

Adding L2 Batch Submitter tests and L2 Node Service tests

167181d

Merging master and fixing conflicts

dcf9d74

karlfloersch approved these changes Jul 6, 2020

View reviewed changes

willmeister merged commit 7530b89 into master Jul 6, 2020

willmeister deleted the YAS-454/L1BatchGeneration branch July 6, 2020 18:00

snario pushed a commit that referenced this pull request Apr 14, 2021

Add reentry protection to ExecutionManager.run() (#175)

df4edec

* Add nonreentrant to ExecutionManager.run() * Cheaper check using uninit'd tx context * Remove extraneous import

blockchaindevsh added a commit to blockchaindevsh/optimism that referenced this pull request Jun 30, 2025

binary release workflow for op-node (ethereum-optimism#175)

6e9e3ba

* binary release for op-node * add a comment * add workflow for op-challenger

theochap pushed a commit that referenced this pull request Dec 10, 2025

fix(derive): inline blob verification into the blob provider (#175)

016f452

Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025

[ARS-01C] Repetitive Authorization Role Declarations ethereum-optimis…

9c8fe46

…m#173 ethereum-optimism#174 ethereum-optimism#175 ethereum-optimism#176

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds L2 Batch Creator #175

Adds L2 Batch Creator #175

Uh oh!

willmeister commented Jul 2, 2020

Uh oh!

karlfloersch left a comment •

edited

Loading

Uh oh!

karlfloersch Jul 6, 2020

Uh oh!

karlfloersch Jul 6, 2020

Uh oh!

willmeister Jul 6, 2020

Uh oh!

willmeister Jul 6, 2020

Uh oh!

karlfloersch Jul 6, 2020

Uh oh!

willmeister Jul 6, 2020

Uh oh!

karlfloersch Jul 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Adds L2 Batch Creator #175

Adds L2 Batch Creator #175

Uh oh!

Conversation

willmeister commented Jul 2, 2020

Description

Metadata

Fixes

Contributing Agreement

Uh oh!

karlfloersch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

willmeister Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Jul 6, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

karlfloersch left a comment •

edited

Loading