Conversation
🦋 Changeset detectedLatest commit: b1fa3f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
385116e to
6b700f0
Compare
|
Enforcing fees may have downstream effects of impacting users that relied on gas price 0 transactions. There isn't really a good way to test these cases in the integration tests without turning on fee enforcement. Users can unset that config at runtime if they so choose |
Codecov Report
@@ Coverage Diff @@
## develop #1736 +/- ##
========================================
Coverage 71.90% 71.90%
========================================
Files 69 69
Lines 2310 2310
Branches 345 345
========================================
Hits 1661 1661
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
6b700f0 to
c5de166
Compare
c5de166 to
45ef210
Compare
d7dddc6 to
2049794
Compare
45ef210 to
911762c
Compare
911762c to
805ba5c
Compare
Enforce fees in the integration tests so that tests can be written to cover the fee rejection logic. This was previously unit tested in geth without end to end test coverage. Projects depend on the error strings returned, so it is important to have test coverage over them. Previously the owner of the gas price oracle was set as the same wallet used in the `l2Wallet` in the integration tests. This would allow it to send 0 gas price transactions, as the sequencer will not charge for transactions from the owner of the gpo. The sequencer also updates the cached values from the contract whenever the owner of the gpo sends a transaction, which results in extra logs and makes the test environment less realistic.
Updates the integration tests to work when fees are enforced by the sequencer. This allows for integration test coverage of the cases where transactions are rejected when fees are too low or too high.
|
We have gotten the go ahead with synthetix to merge this PR |
Description
Enforce fees in the integration tests so that
tests can be written to cover the fee rejection
logic. This was previously unit tested in geth
without end to end test coverage. Projects
depend on the error strings returned, so it is
important to have test coverage over them.
Previously the owner of the gas price oracle was set as
the same wallet used in the
l2Walletin theintegration tests. This would allow it to send
0 gas price transactions, as the sequencer will not
charge for transactions from the owner of the gpo.
The sequencer also updates the cached values
from the contract whenever the owner of the gpo
sends a transaction, which results in extra
logs and makes the test environment less realistic.
Updates the integration tests to work when fees
are enforced by the sequencer. This allows for
integration test coverage of the cases where transactions
are rejected when fees are too low or too high.