You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the integration tests to build JS services using a single Dockerfile rather than multiple Dockerfiles that inherit from a builder image. This fixes the issues we've been seeing where the builder image on Docker Hub gets pulled instead of the locally-build one. The individual service to build is selected via the target attribute in docker-compose.yml.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
❗ Current head 2791549 differs from pull request most recent head 1667185. Consider uploading reports for the commit 1667185 to get more accurate results
I have a similar change to gasPriceForL2 in #1736 which enforces fee payment on L2 meaning that 0 gas price transactions will fail. This was to add test coverage of the case where transactions are sent with a fee that is too small and is rejected at the policy layer by the sequencer
Re: unused Dockerfiles - some of them are still used by the production release system, so I opted to leave them alone until after the regenesis. I can make a PR then that cleans everything up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the integration tests to build JS services using a single Dockerfile rather than multiple Dockerfiles that inherit from a builder image. This fixes the issues we've been seeing where the builder image on Docker Hub gets pulled instead of the locally-build one. The individual service to build is selected via the
targetattribute indocker-compose.yml.