Skip to content

integration-tests: Build using single Dockerfile#1732

Merged
tynes merged 1 commit intoethereum-optimism:regenesis/0.5.0from
mslipper:feat/single-dockerfile
Nov 10, 2021
Merged

integration-tests: Build using single Dockerfile#1732
tynes merged 1 commit intoethereum-optimism:regenesis/0.5.0from
mslipper:feat/single-dockerfile

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Nov 10, 2021

This PR updates the integration tests to build JS services using a single Dockerfile rather than multiple Dockerfiles that inherit from a builder image. This fixes the issues we've been seeing where the builder image on Docker Hub gets pulled instead of the locally-build one. The individual service to build is selected via the target attribute in docker-compose.yml.

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2021

⚠️ No Changeset found

Latest commit: 3cb49a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers M-ci Meta: ci related work A-ops Area: ops labels Nov 10, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021

Codecov Report

Merging #1732 (2791549) into regenesis/0.5.0 (3f58aeb) will not change coverage.
The diff coverage is n/a.

❗ Current head 2791549 differs from pull request most recent head 1667185. Consider uploading reports for the commit 1667185 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           regenesis/0.5.0    #1732   +/-   ##
================================================
  Coverage            72.64%   72.64%           
================================================
  Files                   69       69           
  Lines                 2274     2274           
  Branches               337      337           
================================================
  Hits                  1652     1652           
  Misses                 622      622           
Flag Coverage Δ
batch-submitter 61.56% <ø> (ø)
contracts 87.96% <ø> (ø)
core-utils 57.72% <ø> (ø)
data-transport-layer 38.23% <ø> (ø)
message-relayer 83.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f58aeb...1667185. Read the comment docs.

@mslipper mslipper force-pushed the feat/single-dockerfile branch from e4e57ea to 80ff0bf Compare November 10, 2021 07:04
@github-actions github-actions bot added the A-integration Area: integration tests label Nov 10, 2021
@mslipper mslipper marked this pull request as ready for review November 10, 2021 07:08
@tynes
Copy link
Contributor

tynes commented Nov 10, 2021

Should this also delete the now unused dockerfiles?

@tynes
Copy link
Contributor

tynes commented Nov 10, 2021

I have a similar change to gasPriceForL2 in #1736 which enforces fee payment on L2 meaning that 0 gas price transactions will fail. This was to add test coverage of the case where transactions are sent with a fee that is too small and is rejected at the policy layer by the sequencer

@mslipper mslipper force-pushed the feat/single-dockerfile branch from 2791549 to 1667185 Compare November 10, 2021 07:33
@mslipper
Copy link
Collaborator Author

Re: unused Dockerfiles - some of them are still used by the production release system, so I opted to leave them alone until after the regenesis. I can make a PR then that cleans everything up.

@mslipper mslipper force-pushed the feat/single-dockerfile branch from 1667185 to 3cb49a6 Compare November 10, 2021 07:47
@mslipper mslipper changed the title Build using single Dockerfile integration-tests: Build using single Dockerfile Nov 10, 2021
@tynes tynes merged commit 770ceca into ethereum-optimism:regenesis/0.5.0 Nov 10, 2021
theochap pushed a commit that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-integration Area: integration tests A-ops Area: ops M-ci Meta: ci related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants