feat: more accurate gas-oracle gas metering#1813
Conversation
🦋 Changeset detectedLatest commit: ab2378e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #1813 +/- ##
========================================
Coverage 71.99% 71.99%
========================================
Files 70 70
Lines 2321 2321
Branches 346 346
========================================
Hits 1671 1671
Misses 650 650
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
LGTM from my POV - may want get Karl to take a look as well for sanity. |
155918a to
f265212
Compare
karlfloersch
left a comment
There was a problem hiding this comment.
LGTM! Left a tiny bit of feedback but overall all of the logic looks right.
Compute the gas used in an epoch based on the actual amount of gas used instead of assuming that the full block's worth of gas was used in each block.
Convert the average block gas limit to a `uint64` in the codebase instead of it being used as a `float64`.
f265212 to
ab2378e
Compare
Description
Compute the gas used in an epoch based on the
actual amount of gas used instead of assuming
that the full block's worth of gas was used in
each block.
Convert the average block gas limit to a
uint64in thecodebase instead of it being used as a
float64.Additional context
Minimal changes were done in a way where the existing tests
could ensure there is no regression. The
gas-oracleis notpart of the
integration-testsso thorough review and observingits behavior on kovan is necessary before rolling this out to mainnet.
#1736 is a prerequisite
for getting the
gas-oracleinto the itestsMetadata