-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/validate entities #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianKjerstad
changed the base branch from
main
to
chore/generate-new-dmss-api
August 1, 2023 10:41
KristianKjerstad
force-pushed
the
feat/validate-entities
branch
4 times, most recently
from
August 1, 2023 11:56
56146f9
to
f2dd8c9
Compare
KristianKjerstad
force-pushed
the
feat/validate-entities
branch
from
August 1, 2023 12:32
f2dd8c9
to
9a5047d
Compare
KristianKjerstad
requested review from
soofstad,
netr0m,
eoaksnes and
ingeridhellen
as code owners
August 1, 2023 13:04
KristianKjerstad
force-pushed
the
feat/validate-entities
branch
from
August 1, 2023 13:06
9a5047d
to
b1a825a
Compare
1 task
ingeridhellen
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
waiting for #113 before tests will pass |
chore: cleanup fix: make path concatenation in utils.py os independent
KristianKjerstad
force-pushed
the
feat/validate-entities
branch
from
August 2, 2023 13:57
734969a
to
9310d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
the validation can be turned off in both commands by adding the flag --no-validate-entities
Issues related to this change
closes #103