Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/validate entities #112

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Feat/validate entities #112

merged 3 commits into from
Aug 2, 2023

Conversation

KristianKjerstad
Copy link
Contributor

@KristianKjerstad KristianKjerstad commented Aug 1, 2023

What does this pull request change?

  • add validation of entities to reset command
  • add validation of entities to init command

the validation can be turned off in both commands by adding the flag --no-validate-entities

Issues related to this change

closes #103

@KristianKjerstad KristianKjerstad changed the base branch from main to chore/generate-new-dmss-api August 1, 2023 10:41
@KristianKjerstad KristianKjerstad force-pushed the feat/validate-entities branch 4 times, most recently from 56146f9 to f2dd8c9 Compare August 1, 2023 11:56
Base automatically changed from chore/generate-new-dmss-api to main August 1, 2023 12:00
@KristianKjerstad KristianKjerstad marked this pull request as ready for review August 1, 2023 13:04
@KristianKjerstad KristianKjerstad linked an issue Aug 1, 2023 that may be closed by this pull request
1 task
Copy link
Contributor

@ingeridhellen ingeridhellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

dm_cli/utils/utils.py Outdated Show resolved Hide resolved
dm_cli/utils/utils.py Outdated Show resolved Hide resolved
@KristianKjerstad
Copy link
Contributor Author

waiting for #113 before tests will pass

KristianKjerstad added 3 commits August 2, 2023 15:57
chore: cleanup

fix: make path concatenation in utils.py os independent
@KristianKjerstad KristianKjerstad merged commit 772c477 into main Aug 2, 2023
3 checks passed
@KristianKjerstad KristianKjerstad deleted the feat/validate-entities branch August 2, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(dm-cli): add validation of entities
2 participants