fix: update reset script to work with dm-cli validation flag #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked by equinor/dm-cli#112 |
|
be explicit in ci commands to run with validation |
KristianKjerstad
force-pushed
the
fix/update-reset-script
branch
from
53c1193
to
91411cd
Compare
KristianKjerstad
force-pushed
the
fix/update-reset-script
branch
from
12adc72
to
99aa417
Compare
KristianKjerstad
requested review from
netr0m,
soofstad,
eoaksnes,
ingeridhellen,
awesthouse,
roar-larsen and
pbullhove
as code owners
ingeridhellen
approved these changes
Aug 3, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
add validation as default in the reset all script. Validation can be turned off by adding the flag --no-validate-entities
NB!
after this is merged, you must run dm-cli v 1.0.16 or higher
Issues related to this change
equinor/dm-cli#103