Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/replace references in meta for subpackages #113

Merged

Conversation

KristianKjerstad
Copy link
Contributor

@KristianKjerstad KristianKjerstad commented Aug 2, 2023

What does this pull request change?

When running reset command, all aliases in all sub package's meta must be replaced. Before, only references in the root package's meta info was replaced.

replacing a reference means substituting the alias (e.g. CORE) with the full path (dmss://system/SIMOS)

Issues related to this change

closes #109

@KristianKjerstad KristianKjerstad force-pushed the fix/replace-references-in-meta-for-subpackages branch 2 times, most recently from 6ec9966 to bfef276 Compare August 2, 2023 13:01
@KristianKjerstad KristianKjerstad marked this pull request as ready for review August 2, 2023 13:13
Copy link
Contributor

@ingeridhellen ingeridhellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dm_cli/utils/reference.py Outdated Show resolved Hide resolved
@KristianKjerstad KristianKjerstad force-pushed the fix/replace-references-in-meta-for-subpackages branch from 03bc505 to 07b5fc3 Compare August 2, 2023 13:47
@KristianKjerstad KristianKjerstad merged commit 48d5c6b into main Aug 2, 2023
3 checks passed
@KristianKjerstad KristianKjerstad deleted the fix/replace-references-in-meta-for-subpackages branch August 2, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: resolve relative paths is not working
2 participants