Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/validation of entities #108

Closed
wants to merge 9 commits into from

Conversation

KristianKjerstad
Copy link
Contributor

@KristianKjerstad KristianKjerstad commented Jul 11, 2023

What does this pull request change?

NB! a lot of files are changed, but the files inside the folder dmss_api can be ignored since they are autogenerated

NB! files inside tests/test_data/plugins_example are copied from dm-core-packages and should not require review

Issues related to this change

closes #103

@KristianKjerstad
Copy link
Contributor Author

probably needs equinor/data-modelling-storage-service#470 for ci to pass

@KristianKjerstad KristianKjerstad marked this pull request as ready for review July 12, 2023 07:05
@KristianKjerstad
Copy link
Contributor Author

KristianKjerstad commented Jul 12, 2023

test if validation works in dm cli if wrong type is saved in an attribute, for example text in boolean attr.

update: those issues are catched by the new validation

@KristianKjerstad
Copy link
Contributor Author

validation in dmss is not working properly.

If trying to validate very nested objects (like the resolved root package), then the validation stops before reaching the "deepest" documents

Validation in dm-cli for the reset command is not trivial since we need ALL documents to be uploaded in ALL data sources before validation can start. This is because the order of uploading documents in dm-cli is not well defined. For example, dm-cli might upload all entities before all blueprints. Validation of entities cannot happen unless all blueprints the entity uses are already in dmss.

@KristianKjerstad
Copy link
Contributor Author

replaced by #112

@KristianKjerstad KristianKjerstad deleted the feat/validation-of-entities branch August 1, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(dm-cli): add validation of entities
1 participant