fault filter: reset token bucket on data start#6627
Merged
mattklein123 merged 7 commits intomasterfrom Apr 18, 2019
Merged
Conversation
This change alters the behavior of fault data limiting by resetting the token bucket to a single token when data initially starts streaming. This makes sure that data pacing is as expecting, while still allowing per-second bursting if the data provider is also bursty. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@ryancox PTAL |
ryancox
previously approved these changes
Apr 17, 2019
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@junr03 PTAL |
junr03
reviewed
Apr 18, 2019
test/extensions/filters/http/fault/fault_filter_integration_test.cc
Outdated
Show resolved
Hide resolved
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
junr03
reviewed
Apr 18, 2019
test/extensions/filters/http/fault/fault_filter_integration_test.cc
Outdated
Show resolved
Hide resolved
junr03
previously approved these changes
Apr 18, 2019
Member
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
Up to you re: the pendantic script. My preference would be to have two different PRs to have explicit history. But if that is too obnoxious, then it is probably ok.
Member
Author
|
@junr03 I will split out as I realize what I just did is broken. Will open a separate PR. |
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@junr03 reverted if you want to re-approve. |
junr03
approved these changes
Apr 18, 2019
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Apr 19, 2019
* master: (26 commits) docs: update docs to recommend /retest repokitteh command (envoyproxy#6655) http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646) access log: add response code details to the access log formatter (envoyproxy#6626) build: add ppc build badge to README (envoyproxy#6629) Revert dispatcher stats (envoyproxy#6649) Batch implementation with timer (envoyproxy#6452) fault filter: reset token bucket on data start (envoyproxy#6627) event: update libevent dependency to fix race condition (envoyproxy#6637) examples: standardize docker-compose version and yaml extension (envoyproxy#6613) quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612) router: support customizable retry back-off intervals (envoyproxy#6568) api: create OpenRCA service proto file (envoyproxy#6497) ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503) build: update jinja to 2.10.1. (envoyproxy#6623) tools: check spelling in pre-push hook (envoyproxy#6631) security: blameless postmortem template. (envoyproxy#6553) Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477) add HTTP integration tests exercising timeouts (envoyproxy#6621) event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619) Add tag extractor for RDS route config name (envoyproxy#6618) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change alters the behavior of fault data limiting
by resetting the token bucket to a single token when data
initially starts streaming. This makes sure that data pacing
is as expected, while still allowing per-second bursting if
the data provider is also bursty.
Risk Level: Low
Testing: New and altered existing tests
Docs Changes: N/A
Release Notes: N/A