api: create OpenRCA service proto file#6497
Conversation
voidzcy
force-pushed
the
feature/create_orca_service_proto_file
branch
2 times, most recently
from
4e89193 to
581ea1f
Compare
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks @voidzcy, I'm so excited to see ORCA finally making its way out to the world. I have some minor comments, the only major things to do are (1) decide where to put this in the Envoy API tree and (2) get the design doc published and GH issue opened so we can have others provide input into this. (1) we can discuss in this PR. For (2), I can own this.
There was a problem hiding this comment.
Can you expand in this comment on how request cost names are specified? I think they probably should follow reverse DNS, e.g. com.acme.some_app.queue_length.
There was a problem hiding this comment.
We probably need a bunch more comments here. Let's discuss tomorrow on IM, but I think the first step is for me to create a public version of the design doc and share this as an Envoy issue, then we can crib from that.
|
@htuch Thanks for your help! I will fix the PR once we have an officially finalized design published. Look forward to seeing that! |
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
#6614 is now filed, so let's continue the review. My main suggestion is to put this under udpa (universal data plane API), since that's the new location for things (starting in this PR ;) ) that are not Envoy specific. @mattklein123 do you concur?
/wait
Yes, +1. I will review once we move the files. Thank you. |
voidzcy
force-pushed
the
feature/create_orca_service_proto_file
branch
from
c554cad to
f51e2bd
Compare
voidzcy
force-pushed
the
feature/create_orca_service_proto_file
branch
from
f51e2bd to
7431bc3
Compare
There was a problem hiding this comment.
Can you copy + paste the updated comment from the public ORCA doc here? I made some grammar changes.
api/udpa/service/orca/v1/orca.proto
Outdated
There was a problem hiding this comment.
Can you add a pointer and reference to the public design doc and relevant section?
There was a problem hiding this comment.
Can you add a pointer and reference to the public design doc and relevant section?
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
voidzcy
force-pushed
the
feature/create_orca_service_proto_file
branch
2 times, most recently
from
8daf37f to
c325921
Compare
voidzcy
force-pushed
the
feature/create_orca_service_proto_file
branch
from
c325921 to
bcd8516
Compare
Signed-off-by: Chengyuan Zhang <chengyuanzhang@google.com>
voidzcy
force-pushed
the
feature/create_orca_service_proto_file
branch
from
bcd8516 to
26c75a6
Compare
* master: (26 commits) docs: update docs to recommend /retest repokitteh command (envoyproxy#6655) http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646) access log: add response code details to the access log formatter (envoyproxy#6626) build: add ppc build badge to README (envoyproxy#6629) Revert dispatcher stats (envoyproxy#6649) Batch implementation with timer (envoyproxy#6452) fault filter: reset token bucket on data start (envoyproxy#6627) event: update libevent dependency to fix race condition (envoyproxy#6637) examples: standardize docker-compose version and yaml extension (envoyproxy#6613) quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612) router: support customizable retry back-off intervals (envoyproxy#6568) api: create OpenRCA service proto file (envoyproxy#6497) ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503) build: update jinja to 2.10.1. (envoyproxy#6623) tools: check spelling in pre-push hook (envoyproxy#6631) security: blameless postmortem template. (envoyproxy#6553) Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477) add HTTP integration tests exercising timeouts (envoyproxy#6621) event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619) Add tag extractor for RDS route config name (envoyproxy#6618) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
3 participants
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Created OpenRCA service proto file based on ORCA design
Risk Level: Low
Testing: None
Docs Changes: None
Release Notes: API: created service proto for Open Request Cost Aggregation
[Optional Fixes #Issue]
[Optional Deprecated:]