examples: standardize docker-compose version and yaml extension#6613
Merged
mattklein123 merged 4 commits intoenvoyproxy:masterfrom Apr 18, 2019
Merged
examples: standardize docker-compose version and yaml extension#6613mattklein123 merged 4 commits intoenvoyproxy:masterfrom
mattklein123 merged 4 commits intoenvoyproxy:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Following @moderation comment from this pr to upgrade the docker-compose version for every example.
Standardizing on .yaml extension per their comment
Changing the build script name in grpc-bridge-example to match the documentation
Risk Level: Low
Testing: Manual - brought up every example after upgrading the docker-compose version
Docs Changes: Yes - just matched the new file extensions
Release Notes: No