Implementing Endpoint lease for ClusterLoadAssigment#6477
Merged
htuch merged 15 commits intoenvoyproxy:masterfrom Apr 17, 2019
Merged
Implementing Endpoint lease for ClusterLoadAssigment#6477htuch merged 15 commits intoenvoyproxy:masterfrom
htuch merged 15 commits intoenvoyproxy:masterfrom
Conversation
Pull latest changes from the master
Pull from envoy:master
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
vishalpowar
changed the title
Contributor
Author
|
/assign htuch |
htuch
reviewed
Apr 9, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Looks great, just some minor comments and stats/release notes needed.
Signed-off-by: Vishal Powar <vishalpowar@google.com>
vishalpowar
force-pushed
the
endpoint_lease
branch
from
9e070aa to
42c808a
Compare
htuch
suggested changes
Apr 12, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Still looks good modulo a few comments.
/wait
Signed-off-by: Vishal Powar <vishalpowar@google.com>
vishalpowar
force-pushed
the
endpoint_lease
branch
2 times, most recently
from
d3b30b0 to
5a2e85c
Compare
htuch
suggested changes
Apr 15, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, just a few last nits.
/wait
htuch
previously approved these changes
Apr 16, 2019
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Thanks @vishalpowar! Can you merge master to resolve conflict?
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
Signed-off-by: Vishal Powar <vishalpowar@google.com>
vishalpowar
force-pushed
the
endpoint_lease
branch
from
4a9d146 to
091504a
Compare
htuch
approved these changes
Apr 16, 2019
Contributor
Author
|
/retest |
|
🔨 rebuilding |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Apr 19, 2019
* master: (26 commits) docs: update docs to recommend /retest repokitteh command (envoyproxy#6655) http timeout integration test: wait for 15s for upstream reset (envoyproxy#6646) access log: add response code details to the access log formatter (envoyproxy#6626) build: add ppc build badge to README (envoyproxy#6629) Revert dispatcher stats (envoyproxy#6649) Batch implementation with timer (envoyproxy#6452) fault filter: reset token bucket on data start (envoyproxy#6627) event: update libevent dependency to fix race condition (envoyproxy#6637) examples: standardize docker-compose version and yaml extension (envoyproxy#6613) quiche: Implement SpdyUnsafeArena using SpdySimpleArena (envoyproxy#6612) router: support customizable retry back-off intervals (envoyproxy#6568) api: create OpenRCA service proto file (envoyproxy#6497) ext_authz: option for clearing route cache of authorized requests (envoyproxy#6503) build: update jinja to 2.10.1. (envoyproxy#6623) tools: check spelling in pre-push hook (envoyproxy#6631) security: blameless postmortem template. (envoyproxy#6553) Implementing Endpoint lease for ClusterLoadAssigment (envoyproxy#6477) add HTTP integration tests exercising timeouts (envoyproxy#6621) event: fix DispatcherImplTest::InitializeStats flake (envoyproxy#6619) Add tag extractor for RDS route config name (envoyproxy#6618) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Add support for specifying _stale_after timeout as part of ClusterLoadAssignment
Risk Level: Low
Optional Feature that is triggered by the Management Server. Defaults to noop.
Testing: Unit test
Docs Changes: None
Release Notes: None
Fixes #6420