test: fix nit after #2591#2601
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Feb 15, 2018
dio:nits-after-2591
Merged
Conversation
htuch
reviewed
Feb 14, 2018
Member
Author
There was a problem hiding this comment.
Ah, OK. BTW @htuch do you think it is worth adding more tests as V2 YAML in this test file?
Member
There was a problem hiding this comment.
Generally, moving as much as possible to v2 YAML will be a good thing. I think the best model to do it is organically, e.g. as we go and modify or add new tests, but any cleanup is always appreciated.
Contributor
|
Looks like the TSAN failure is a flake, I am investigating that. When you address @htuch's comment and push a new commit it will re-run the test. |
Member
|
Please merge master to pick up #2613, this should fix CI TSAN. |
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Member
Author
|
It seems fine now 🙌 |
htuch
approved these changes
Feb 15, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* add configurable metric export interval * format * update env variable
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Add a setPerTryIdleTimeoutSeconds method to EngineBuilder. Add tests for setPerTryIdleTimeoutSeconds and setStreamIdleTimeoutSeconds. Minor cleanup of envoy_config_test.cc. Part of #2498 Risk Level: Low Testing: Added unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Add a setPerTryIdleTimeoutSeconds method to EngineBuilder. Add tests for setPerTryIdleTimeoutSeconds and setStreamIdleTimeoutSeconds. Minor cleanup of envoy_config_test.cc. Part of #2498 Risk Level: Low Testing: Added unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: fix nit after #2591
Description:
Fix some nit for PR #2591.
Risk Level: Low
Testing:
unit
Docs Changes:
N/A
Release Notes:
N/A