testing: Add some more debug scaffolding around the hotrestart_test#2604
Merged
htuch merged 8 commits intoenvoyproxy:masterfrom Feb 18, 2018
Merged
testing: Add some more debug scaffolding around the hotrestart_test#2604htuch merged 8 commits intoenvoyproxy:masterfrom
htuch merged 8 commits intoenvoyproxy:masterfrom
Conversation
This can be factored out into a test helper library if it seems more broadly useful (which it was intended to be). Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
ggreenway
requested changes
Feb 14, 2018
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
This is a really nice cleanup of this test! A few comments, but I really like it overall.
test/integration/hotrestart_test.sh
Outdated
|
|
||
| CURRENT_TEST="NONE" | ||
| function start_test() { | ||
| #update_elapsed_time |
| --admin-address-path "${ADMIN_ADDRESS_PATH_0}" | ||
|
|
||
| FIRST_SERVER_PID=$! | ||
| sleep 3 |
Member
There was a problem hiding this comment.
Without some time here (not that I love arbitrary sleep in test...), couldn't we send signals to the process before it has installed signal handlers?
jmarantz
commented
Feb 14, 2018
test/integration/hotrestart_test.sh
Outdated
|
|
||
| CURRENT_TEST="NONE" | ||
| function start_test() { | ||
| #update_elapsed_time |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
ggreenway
previously approved these changes
Feb 14, 2018
Member
|
Need to resolve merge conflicts |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
htuch
reviewed
Feb 15, 2018
test/integration/hotrestart_test.sh
Outdated
| local src="${BASH_SOURCE[$i]}" | ||
| [ -z "$src" ] && src=non_file_source | ||
| local canonical_dir=$(cd $(dirname "$src") && pwd) | ||
| local short_dir=${canonical_dir#*/net/instaweb/} |
Member
There was a problem hiding this comment.
LGTM if you can cleanup this stuff.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Member
|
More merge conflicts |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
|
@htuch for final review pass |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* add configurable metric export interval * format * update env variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
hotrestart_test is difficult to debug when it goes wrong, because there are many different sub-tests within it, and it's hard to track where a failure occurs. This borrows some sh-test debug scaffolding from PageSpeed where it's proved useful.
Risk Level: Low
Testing:
//test/integration:hotrestart_test
//test/integration:hotrestart_test --runs_per_test=10 --jobs=1
//test/integration:hotrestart_test --config=tsan --runs_per_test=10 --jobs=1
Release Notes: N/A