Merged
Conversation
Some of this is not stupid coverage and should definitely be covered. Probably worth a more complete audit depending on time availability. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@alyssawilk FYI I think the auto codec integration was lost when we switched over the integration tests but I'm not sure. This should get it back. |
Signed-off-by: Matt Klein <mklein@lyft.com>
ggreenway
approved these changes
Feb 1, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Add a setPerTryIdleTimeoutSeconds method to EngineBuilder. Add tests for setPerTryIdleTimeoutSeconds and setStreamIdleTimeoutSeconds. Minor cleanup of envoy_config_test.cc. Part of #2498 Risk Level: Low Testing: Added unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
…he Java and Obj-C builders (#2603) Add various methods to C++ EngineBuilder to bring it to parity with the Java and Obj-C builders addStatsSinks() addDnsMinRefreshSeconds() addMaxConnectionsPerHost() enableAdminInterface() enableHappyEyeballs() enableHttp3() enableInterfaceBinding() enableDrainPostDnsRefresh() enableH2ExtendKeepaliveTimeout() enforceTrustChainVerification() Part of #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Add support for String Accessors to the C++ engine builder Introduces a C++ StringAccessor interface and method to convert to an envoy_string_accessor. Minor cleanup of key_value_store handling in engine_builder.cc Part of: #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.rst Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
As discussed in the weekly meeting, this does not provide a C++ implementation of Platform filters, merely the ability to configure Envoy to use them. Part of: #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.rst Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Add a setPerTryIdleTimeoutSeconds method to EngineBuilder. Add tests for setPerTryIdleTimeoutSeconds and setStreamIdleTimeoutSeconds. Minor cleanup of envoy_config_test.cc. Part of #2498 Risk Level: Low Testing: Added unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
…he Java and Obj-C builders (#2603) Add various methods to C++ EngineBuilder to bring it to parity with the Java and Obj-C builders addStatsSinks() addDnsMinRefreshSeconds() addMaxConnectionsPerHost() enableAdminInterface() enableHappyEyeballs() enableHttp3() enableInterfaceBinding() enableDrainPostDnsRefresh() enableH2ExtendKeepaliveTimeout() enforceTrustChainVerification() Part of #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Add support for String Accessors to the C++ engine builder Introduces a C++ StringAccessor interface and method to convert to an envoy_string_accessor. Minor cleanup of key_value_store handling in engine_builder.cc Part of: #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.rst Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
As discussed in the weekly meeting, this does not provide a C++ implementation of Platform filters, merely the ability to configure Envoy to use them. Part of: #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.rst Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of this is not stupid coverage and should definitely be covered.
Probably worth a more complete audit depending on time availability.
Risk Level: Low
Testing: UT/integration
Docs Changes: N/A
Release Notes: N/A