healthcheck: Allow setting host header value of HTTP health checker#2591
Merged
htuch merged 8 commits intoenvoyproxy:masterfrom Feb 13, 2018
dio:add-host-http-healthcheck
Merged
healthcheck: Allow setting host header value of HTTP health checker#2591htuch merged 8 commits intoenvoyproxy:masterfrom dio:add-host-http-healthcheck
htuch merged 8 commits intoenvoyproxy:masterfrom
dio:add-host-http-healthcheck
Conversation
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Very nice, thanks! Question about v1 support.
source/common/config/cds_json.cc
Outdated
| const std::string hc_type = json_health_check.getString("type"); | ||
| if (hc_type == "http") { | ||
| health_check.mutable_http_health_check()->set_path(json_health_check.getString("path")); | ||
| if (json_health_check.hasObject("host")) { |
Member
There was a problem hiding this comment.
Do we need v1 support? If so we need to add v1 docs. Otherwise I would just drop it.
Member
Author
There was a problem hiding this comment.
I have removed the v1 support in the following commit 5937131
| } | ||
|
|
||
| void setupServiceValidationWithCustomHostValueHC(const std::string& host) { | ||
| std::string json = fmt::format(R"EOF( |
Member
There was a problem hiding this comment.
If we drop v1 support, let's make this a v2 YAML config for testing?
Member
Author
There was a problem hiding this comment.
OK, I have it in v2 YAML on b3f2c8f. Thanks for reviewing @mattklein123!
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
htuch
approved these changes
Feb 13, 2018
| } | ||
|
|
||
| TEST_F(HttpHealthCheckerImplTest, SuccessServiceCheckWithCustomHostValue) { | ||
| std::string host = "www.envoyproxy.io"; |
htuch
pushed a commit
that referenced
this pull request
Feb 15, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* expose service port * fix? * fix?? * fix * last fix * typo * port * hard code * use server port * last fix * remove spaces
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Add support for PAC proxies. Fixes envoyproxy/envoy-mobile#2531. Risk Level: Low, the change should be additive and it's guarded with an engine builder flag (`enableProxying(true/false)` that's disabled by default. Testing: Manual testing for PAC proxies, integrations tests for other types of proxies. Docs Changes: N/A Release Notes: WIP Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Add support for PAC proxies. Fixes envoyproxy/envoy-mobile#2531. Risk Level: Low, the change should be additive and it's guarded with an engine builder flag (`enableProxying(true/false)` that's disabled by default. Testing: Manual testing for PAC proxies, integrations tests for other types of proxies. Docs Changes: N/A Release Notes: WIP Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title: healthcheck: Allow setting host header value of HTTP health checker
Description:
This patch enables setting host header value as mentioned in HttpHealthCheck.host.
Risk Level: Low
Testing:
unit and manual testing
Docs Changes: envoyproxy/data-plane-api#493
Release Notes:
Enable setting host header value for HTTP HC
Fixes: #2450
API Changes:
envoyproxy/data-plane-api#493