thread: annotation support when !OS X.#2603
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Feb 15, 2018
Merged
Conversation
Provide support to allow folks to use thread annotations across Envoy in the absence of a full solution to envoyproxy#2571. Signed-off-by: Harvey Tuch <htuch@google.com>
ggreenway
approved these changes
Feb 14, 2018
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
Yes! I'm a huge fan of these types of annotations.
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
…he Java and Obj-C builders (#2603) Add various methods to C++ EngineBuilder to bring it to parity with the Java and Obj-C builders addStatsSinks() addDnsMinRefreshSeconds() addMaxConnectionsPerHost() enableAdminInterface() enableHappyEyeballs() enableHttp3() enableInterfaceBinding() enableDrainPostDnsRefresh() enableH2ExtendKeepaliveTimeout() enforceTrustChainVerification() Part of #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
…he Java and Obj-C builders (#2603) Add various methods to C++ EngineBuilder to bring it to parity with the Java and Obj-C builders addStatsSinks() addDnsMinRefreshSeconds() addMaxConnectionsPerHost() enableAdminInterface() enableHappyEyeballs() enableHttp3() enableInterfaceBinding() enableDrainPostDnsRefresh() enableH2ExtendKeepaliveTimeout() enforceTrustChainVerification() Part of #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.txt Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide support to allow folks to use thread annotations across Envoy in
the absence of a full solution to #2571.
Signed-off-by: Harvey Tuch htuch@google.com