logging: Assert fail on pthread without log lock#2619
Merged
ggreenway merged 2 commits intoenvoyproxy:masterfrom Feb 15, 2018
Merged
logging: Assert fail on pthread without log lock#2619ggreenway merged 2 commits intoenvoyproxy:masterfrom
ggreenway merged 2 commits intoenvoyproxy:masterfrom
Conversation
…ed logging. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
dnoe
approved these changes
Feb 15, 2018
ggreenway
approved these changes
Feb 15, 2018
dnoe
pushed a commit
that referenced
this pull request
Feb 15, 2018
…ation (#2623) Description: Reverts #2613 the revert of #2568 Fixed the underlying issue which was that logging was not initialized during validation, so it ran lockless. This caused intermittent tsan errors. Although #2619 makes the failure immediate and consistent by asserting that logging has been initialized prior to spawning any threads. Risk Level: Medium -- the earlier #2568 caused intermittent tsan errors which we believe to be fixed, but #2568 was medium-risk in the first place. Release Notes: N/A
lita
pushed a commit
to lita/envoy
that referenced
this pull request
Feb 15, 2018
…nitialized logging. (envoyproxy#2619)" This reverts commit 98fe3e8.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Add support for String Accessors to the C++ engine builder Introduces a C++ StringAccessor interface and method to convert to an envoy_string_accessor. Minor cleanup of key_value_store handling in engine_builder.cc Part of: #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.rst Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Add support for String Accessors to the C++ engine builder Introduces a C++ StringAccessor interface and method to convert to an envoy_string_accessor. Minor cleanup of key_value_store handling in engine_builder.cc Part of: #2498 Risk Level: Low Testing: New unit tests Docs Changes: N/A Release Notes: Updated version_history.rst Signed-off-by: Ryan Hamilton <rch@google.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This helps Envoy fail fast in any build, if someone attempts to create a thread without having first set up mutexes for logging.
This would've helped catch the regression caused (at least in part) by #2568, which occasionally (but not always) has tsan problems on test/integration:hotrestart_test. Before rolling #2568 forward I wanted to establish that bad state is caught deterministicly.
Risk Level: Low
Release Notes: N/A