bazel: update to 6.0.0#24667
Merged
keith merged 5 commits intoenvoyproxy:release/v1.24from Jan 3, 2023
Merged
Conversation
This reverts commit dede92e. Originally this was reverted because of envoyproxy#23985 Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Fixes envoyproxy#23390 This is an edge case, upstream issue: bazelbuild/bazel-skylib#404 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
This rule seems to have been used a lot more in the past, likely pre rules_foreign_cc. At this point it was only used for boringssl_fips, and we can easily replace that use with a normal genrule that just calls the same script. The script had to be updated slightly to remove the few dependencies on bazel specifics. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
jwendell
force-pushed
the
bump-bazel-600-124
branch
from
dbc898a to
201a351
Compare
Member
Author
|
Hey folks, can I have an approval here? Bazel 6.0 is being used in |
Member
|
/retest |
|
Retrying Azure Pipelines: |
keith
approved these changes
Jan 3, 2023
Member
keith
left a comment
keith
left a comment
There was a problem hiding this comment.
looks good, the current failure here is bogus, but you might have to push an empty commit to fix it
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also cherry-picks a couple of needed commits from main