bazel: update to 6.0.0

.bazelrc

@@ -172,7 +172,7 @@ build:coverage --define=dynamic_link_tests=true
 build:coverage --define=ENVOY_CONFIG_COVERAGE=1
 build:coverage --cxxopt="-DENVOY_CONFIG_COVERAGE=1"
 build:coverage --coverage_support=@envoy//bazel/coverage:coverage_support
-build:coverage --test_env=CC_CODE_COVERAGE_SCRIPT=external/envoy/bazel/coverage/collect_cc_coverage.sh
+build:coverage --test_env=CC_CODE_COVERAGE_SCRIPT=bazel/coverage/collect_cc_coverage.sh
 build:coverage --test_env=HEAPCHECK=
 build:coverage --combined_report=lcov
 build:coverage --strategy=TestRunner=sandboxed,local
@@ -373,6 +373,7 @@ build:windows --define tcmalloc=disabled
 build:windows --define wasm=disabled
 build:windows --define manual_stamp=manual_stamp
 build:windows --cxxopt="/std:c++17"
+build:windows --output_groups=+pdb_file
 
 # TODO(wrowe,sunjayBhatia): Resolve bugs upstream in curl and rules_foreign_cc
 # See issue https://github.com/bazelbuild/rules_foreign_cc/issues/301

.bazelversion

@@ -1 +1 @@
-6.0.0-pre.20220706.4
+6.0.0

bazel/BUILD

@@ -304,15 +304,17 @@ config_setting(
 bool_flag(
     name = "http3",
     build_setting_default = True,
-    visibility = ["//visibility:private"],
+    # TODO(keith): make private again https://github.com/bazelbuild/bazel-skylib/issues/404
+    # visibility = ["//visibility:private"],
 )
 
 config_setting(
     name = "disable_http3_setting",
     flag_values = {
         ":http3": "False",
     },
-    visibility = ["//visibility:private"],
+    # TODO(keith): make private again https://github.com/bazelbuild/bazel-skylib/issues/404
+    # visibility = ["//visibility:private"],
 )
 
 selects.config_setting_group(
@@ -331,7 +333,8 @@ config_setting(
 config_setting(
     name = "disable_hot_restart_setting",
     values = {"define": "hot_restart=disabled"},
-    visibility = ["//visibility:private"],
+    # TODO(keith): make private again https://github.com/bazelbuild/bazel-skylib/issues/404
+    # visibility = ["//visibility:private"],
 )
 
 selects.config_setting_group(

bazel/EXTERNAL_DEPS.md

@@ -31,32 +31,6 @@ This is the preferred style of adding dependencies that use CMake for their buil
    `external_deps` attribute.
 4. `bazel test //test/...`
 
-
-## genrule repository
-
-This is the newer style of adding dependencies with no upstream Bazel configs.
-It wraps the dependency's native build tooling in a Bazel-aware shell script,
-installing to a Bazel-managed prefix.
-
-The shell script is executed by Bash, with a few Bazel-specific extensions.
-See the [Bazel docs for "genrule"](https://docs.bazel.build/versions/master/be/general.html#genrule)
-for details on Bazel's shell extensions.
-
-1. Add a BUILD file in [`bazel/external/`](external/), using a `genrule` target
-   to build the dependency. Please do not add BUILD logic that replaces the
-   dependency's upstream build tooling.
-2. Define a new Bazel repository in [`bazel/repositories.bzl`](repositories.bzl),
-   in the `envoy_dependencies()` function. The repository may use `genrule_repository`
-   from [`bazel/genrule_repository.bzl`](genrule_repository.bzl) to place large
-   genrule shell commands into a separate file.
-3. Reference your new external dependency in some `envoy_cc_library` via Y in the
-   `external_deps` attribute.
-4. `bazel test //test/...`
-
-Dependencies between external libraries can use the standard Bazel dependency
-resolution logic, using the `$(location)` shell extension to resolve paths
-to binaries, libraries, headers, etc.
-
 # Adding external dependencies to Envoy (Python)
 
 Python dependencies should be added via `pip` and `rules_python`. The process

bazel/external/BUILD

@@ -1,5 +1,7 @@
 licenses(["notice"])  # Apache 2
 
+exports_files(["boringssl_fips.genrule_cmd"])
+
 # Use a wrapper cc_library with an empty source source file to force
 # compilation of other cc_library targets that only list *.a sources.
 cc_library(

bazel/external/boringssl_fips.BUILD

@@ -1,5 +1,3 @@
-load(":genrule_cmd.bzl", "genrule_cmd")
-
 licenses(["notice"])  # Apache 2
 
 cc_library(
@@ -31,5 +29,6 @@ genrule(
         "crypto/libcrypto.a",
         "ssl/libssl.a",
     ],
-    cmd = genrule_cmd("@envoy//bazel/external:boringssl_fips.genrule_cmd"),
+    cmd = "$(location {}) $(location crypto/libcrypto.a) $(location ssl/libssl.a)".format("@envoy//bazel/external:boringssl_fips.genrule_cmd"),
+    exec_tools = ["@envoy//bazel/external:boringssl_fips.genrule_cmd"],
 )

bazel/external/boringssl_fips.genrule_cmd

@@ -12,31 +12,32 @@ if [[ `uname` != "Linux" || `uname -m` != "x86_64" ]]; then
 fi
 
 # Bazel magic.
-ROOT=$$(dirname $(rootpath boringssl/BUILDING.md))/..
-pushd $$ROOT
+# ROOT=$(dirname $(rootpath boringssl/BUILDING.md))/..
+ROOT=./external/boringssl_fips
+pushd "$ROOT"
 
 # Build tools requirements:
 # - Clang compiler version 7.0.1 (https://releases.llvm.org/download.html)
 # - Go programming language version 1.12.7 (https://golang.org/dl/)
 # - Ninja build system version 1.9.0 (https://github.com/ninja-build/ninja/releases)
 
-# Override $$PATH for build tools, to avoid picking up anything else.
-export PATH="$$(dirname `which cmake`):/usr/bin:/bin"
+# Override $PATH for build tools, to avoid picking up anything else.
+export PATH="$(dirname `which cmake`):/usr/bin:/bin"
 
 # Clang 7.0.1
 VERSION=7.0.1
 SHA256=02ad925add5b2b934d64c3dd5cbd1b2002258059f7d962993ba7f16524c3089c
 PLATFORM="x86_64-linux-gnu-ubuntu-16.04"
 
-curl -sLO https://releases.llvm.org/"$$VERSION"/clang+llvm-"$$VERSION"-"$$PLATFORM".tar.xz \
-  && echo "$$SHA256" clang+llvm-"$$VERSION"-"$$PLATFORM".tar.xz | sha256sum --check
-tar xf clang+llvm-"$$VERSION"-"$$PLATFORM".tar.xz
+curl -sLO https://releases.llvm.org/"$VERSION"/clang+llvm-"$VERSION"-"$PLATFORM".tar.xz \
+  && echo "$SHA256" clang+llvm-"$VERSION"-"$PLATFORM".tar.xz | sha256sum --check
+tar xf clang+llvm-"$VERSION"-"$PLATFORM".tar.xz
 
-export HOME="$$PWD"
-printf "set(CMAKE_C_COMPILER \"clang\")\nset(CMAKE_CXX_COMPILER \"clang++\")\n" > $${HOME}/toolchain
-export PATH="$$PWD/clang+llvm-$$VERSION-$$PLATFORM/bin:$$PATH"
+export HOME="$PWD"
+printf "set(CMAKE_C_COMPILER \"clang\")\nset(CMAKE_CXX_COMPILER \"clang++\")\n" > ${HOME}/toolchain
+export PATH="$PWD/clang+llvm-$VERSION-$PLATFORM/bin:$PATH"
 
-if [[ `clang --version | head -1 | awk '{print $$3}'` != "$$VERSION" ]]; then
+if [[ `clang --version | head -1 | awk '{print $3}'` != "$VERSION" ]]; then
   echo "ERROR: Clang version doesn't match."
   exit 1
 fi
@@ -46,15 +47,15 @@ VERSION=1.12.7
 SHA256=66d83bfb5a9ede000e33c6579a91a29e6b101829ad41fffb5c5bb6c900e109d9
 PLATFORM="linux-amd64"
 
-curl -sLO https://dl.google.com/go/go"$$VERSION"."$$PLATFORM".tar.gz \
-  && echo "$$SHA256" go"$$VERSION"."$$PLATFORM".tar.gz | sha256sum --check
-tar xf go"$$VERSION"."$$PLATFORM".tar.gz
+curl -sLO https://dl.google.com/go/go"$VERSION"."$PLATFORM".tar.gz \
+  && echo "$SHA256" go"$VERSION"."$PLATFORM".tar.gz | sha256sum --check
+tar xf go"$VERSION"."$PLATFORM".tar.gz
 
-export GOPATH="$$PWD/gopath"
-export GOROOT="$$PWD/go"
-export PATH="$$GOPATH/bin:$$GOROOT/bin:$$PATH"
+export GOPATH="$PWD/gopath"
+export GOROOT="$PWD/go"
+export PATH="$GOPATH/bin:$GOROOT/bin:$PATH"
 
-if [[ `go version | awk '{print $$3}'` != "go$$VERSION" ]]; then
+if [[ `go version | awk '{print $3}'` != "go$VERSION" ]]; then
   echo "ERROR: Go version doesn't match."
   exit 1
 fi
@@ -64,13 +65,13 @@ VERSION=1.9.0
 SHA256=1b1235f2b0b4df55ac6d80bbe681ea3639c9d2c505c7ff2159a3daf63d196305
 PLATFORM="linux"
 
-curl -sLO https://github.com/ninja-build/ninja/releases/download/v"$$VERSION"/ninja-"$$PLATFORM".zip \
-  && echo "$$SHA256" ninja-"$$PLATFORM".zip | sha256sum --check
-unzip -o ninja-"$$PLATFORM".zip
+curl -sLO https://github.com/ninja-build/ninja/releases/download/v"$VERSION"/ninja-"$PLATFORM".zip \
+  && echo "$SHA256" ninja-"$PLATFORM".zip | sha256sum --check
+unzip -o ninja-"$PLATFORM".zip
 
-export PATH="$$PWD:$$PATH"
+export PATH="$PWD:$PATH"
 
-if [[ `ninja --version` != "$$VERSION" ]]; then
+if [[ `ninja --version` != "$VERSION" ]]; then
   echo "ERROR: Ninja version doesn't match."
   exit 1
 fi
@@ -80,7 +81,7 @@ rm -rf boringssl/build
 
 # Build BoringSSL.
 cd boringssl
-mkdir build && cd build && cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=$${HOME}/toolchain -DFIPS=1 -DCMAKE_BUILD_TYPE=Release ..
+mkdir build && cd build && cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=${HOME}/toolchain -DFIPS=1 -DCMAKE_BUILD_TYPE=Release ..
 ninja
 ninja run_tests
 
@@ -92,5 +93,5 @@ fi
 
 # Move compiled libraries to the expected destinations.
 popd
-mv $$ROOT/boringssl/build/crypto/libcrypto.a $(execpath crypto/libcrypto.a)
-mv $$ROOT/boringssl/build/ssl/libssl.a $(execpath ssl/libssl.a)
+mv $ROOT/boringssl/build/crypto/libcrypto.a $1
+mv $ROOT/boringssl/build/ssl/libssl.a $2

bazel/repositories.bzl

@@ -1,5 +1,4 @@
 load(":dev_binding.bzl", "envoy_dev_binding")
-load(":genrule_repository.bzl", "genrule_repository")
 load("@envoy_api//bazel:envoy_http_archive.bzl", "envoy_http_archive")
 load("@envoy_api//bazel:external_deps.bzl", "load_repository_locations")
 load(":repository_locations.bzl", "PROTOC_VERSIONS", "REPOSITORY_LOCATIONS_SPEC")
@@ -33,14 +32,6 @@ def external_http_archive(name, **kwargs):
         **kwargs
     )
 
-# Use this macro to reference any genrule_repository sourced from bazel/repository_locations.bzl.
-def external_genrule_repository(name, **kwargs):
-    location = REPOSITORY_LOCATIONS[name]
-    genrule_repository(
-        name = name,
-        **dict(location, **kwargs)
-    )
-
 def _default_envoy_build_config_impl(ctx):
     ctx.file("WORKSPACE", "")
     ctx.file("BUILD.bazel", "")
@@ -271,9 +262,8 @@ def _boringssl():
     )
 
 def _boringssl_fips():
-    external_genrule_repository(
+    external_http_archive(
         name = "boringssl_fips",
-        genrule_cmd_file = "@envoy//bazel/external:boringssl_fips.genrule_cmd",
         build_file = "@envoy//bazel/external:boringssl_fips.BUILD",
         patches = ["@envoy//bazel/external:boringssl_fips.patch"],
     )

bazel/repository_locations.bzl

@@ -1376,6 +1376,19 @@ REPOSITORY_LOCATIONS_SPEC = dict(
         release_date = "2022-03-30",
         cpe = "N/A",
     ),
+    rules_license = dict(
+        project_name = "rules_license",
+        project_desc = "Bazel rules for checking open source licenses",
+        project_url = "https://github.com/bazelbuild/rules_license",
+        version = "0.0.3",
+        sha256 = "00ccc0df21312c127ac4b12880ab0f9a26c1cff99442dc6c5a331750360de3c3",
+        urls = ["https://github.com/bazelbuild/rules_license/releases/download/{version}/rules_license-{version}.tar.gz"],
+        use_category = ["build", "dataplane_core", "controlplane"],
+        release_date = "2022-05-28",
+        cpe = "N/A",
+        license = "Apache-2.0",
+        license_url = "https://github.com/bazelbuild/rules_license/blob/{version}/LICENSE",
+    ),
 )
 
 def _compiled_protoc_deps(locations, versions):