bazel: remove genrule_repository#23768
Merged
htuch merged 1 commit intoenvoyproxy:mainfrom Nov 1, 2022
Merged
Conversation
This rule seems to have been used a lot more in the past, likely pre rules_foreign_cc. At this point it was only used for boringssl_fips, and we can easily replace that use with a normal genrule that just calls the same script. The script had to be updated slightly to remove the few dependencies on bazel specifics. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Member
Author
|
my actual motivation here was bazel keeps messing with Labels which broke the genrule_cmd accessor yet again. I think I can come up with a new solution for that but it doesn't seem like we need to maintain this anymore either |
repokitteh-read-only
bot
removed
the
deps
jwendell
pushed a commit
to jwendell/envoy
that referenced
this pull request
Dec 22, 2022
This rule seems to have been used a lot more in the past, likely pre rules_foreign_cc. At this point it was only used for boringssl_fips, and we can easily replace that use with a normal genrule that just calls the same script. The script had to be updated slightly to remove the few dependencies on bazel specifics. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com> Signed-off-by: Jonh Wendell <jwendell@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule seems to have been used a lot more in the past, likely pre rules_foreign_cc. At this point it was only used for boringssl_fips, and we can easily replace that use with a normal genrule that just calls the same script. The script had to be updated slightly to remove the few dependencies on bazel specifics.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com