Skip to content

bazel: update to 6.0.0rc4#24235

Merged
keith merged 5 commits intoenvoyproxy:mainfrom
keith:ks/bazel-update-to-6.0.0rc2
Dec 7, 2022
Merged

bazel: update to 6.0.0rc4#24235
keith merged 5 commits intoenvoyproxy:mainfrom
keith:ks/bazel-update-to-6.0.0rc2

Conversation

@keith
Copy link
Member

@keith keith commented Nov 28, 2022

This reverts commit dede92e. Originally this was reverted because of #23985

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24235 was opened by keith.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Nov 28, 2022
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @phlax

🐱

Caused by: #24235 was opened by keith.

see: more, trace.

@keith
Copy link
Member Author

keith commented Nov 28, 2022

hoping CI will catch with #24203

@keith
Copy link
Member Author

keith commented Nov 30, 2022

ci did catch the coverage issue, working on the fix here

@keith
Copy link
Member Author

keith commented Nov 30, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24235 (comment) was created by @keith.

see: more, trace.

@keith
Copy link
Member Author

keith commented Nov 30, 2022

I bisected the coverage change to bazelbuild/bazel@943e8cf

@keith
Copy link
Member Author

keith commented Nov 30, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24235 (comment) was created by @keith.

see: more, trace.

@keith
Copy link
Member Author

keith commented Dec 1, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24235 (comment) was created by @keith.

see: more, trace.

@keith keith requested a review from phlax December 1, 2022 18:27
@keith keith marked this pull request as ready for review December 2, 2022 00:52
@keith
Copy link
Member Author

keith commented Dec 6, 2022

@phlax want to look at this one too?

keith added 4 commits December 7, 2022 03:54
This reverts commit dede92e. Originally
this was reverted because of envoyproxy#23985

Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith force-pushed the ks/bazel-update-to-6.0.0rc2 branch from 4cdb56a to e93b9ac Compare December 7, 2022 03:55
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith changed the title bazel: update to 6.0.0rc2 bazel: update to 6.0.0rc4 Dec 7, 2022
@keith keith enabled auto-merge (squash) December 7, 2022 03:56
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm deps

thanks @keith

@keith keith merged commit 54e7d0e into envoyproxy:main Dec 7, 2022
@keith keith deleted the ks/bazel-update-to-6.0.0rc2 branch December 7, 2022 11:58
@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Dec 7, 2022
jpsim added a commit that referenced this pull request Dec 7, 2022
….h-into-multiple-header-files

* origin/main:
  Add setRequestDecoder to ResponseEncoder interface (#24368)
  downstream: refactoring code to remove listener hard deps (#24394)
  lb api: moving load balancing policy specific configuration to extension configuration (#23967)
  ci: Skip docker/examples verification for docs or mobile only changes (#24417)
  ci: run mobile GitHub Actions on every PR (#24407)
  mobile: remove `bump_lyft_support_rotation.sh` script (#24404)
  Add file size to DirectoryEntry (#24176)
  bazel: update to 6.0.0rc4 (#24235)
  bazel: update rules_rust (#24409)
  Ecds config dump recommit (#24384)
  bazel: add another config_setting incompatible flag (#24270)
  listeners: moving listeners to extension directory (#24248)
  mobile: build Swift with whole module optimization (#24396)
  ci: update `actions/setup-java` from v1 to v3.8 (#24393)

Signed-off-by: JP Simard <jp@jpsim.com>
jpsim added a commit that referenced this pull request Dec 8, 2022
…-cpp-to-latest-version

* origin/main: (23 commits)
  Reduce Route memory utilization by avoiding RuntimeData instances when not needed (#24327)
  build: fix compile error for mac (#24429)
  postgres: support for upstream SSL (#23990)
  iOS: split `EnvoyEngine.h` into multiple header files (#24397)
  mobile: check for pending exceptions after JNI call (#24361)
  Remove uneccessary `this->` from mobile engine builder (#24389)
  Add setRequestDecoder to ResponseEncoder interface (#24368)
  downstream: refactoring code to remove listener hard deps (#24394)
  lb api: moving load balancing policy specific configuration to extension configuration (#23967)
  ci: Skip docker/examples verification for docs or mobile only changes (#24417)
  ci: run mobile GitHub Actions on every PR (#24407)
  mobile: remove `bump_lyft_support_rotation.sh` script (#24404)
  Add file size to DirectoryEntry (#24176)
  bazel: update to 6.0.0rc4 (#24235)
  bazel: update rules_rust (#24409)
  Ecds config dump recommit (#24384)
  bazel: add another config_setting incompatible flag (#24270)
  listeners: moving listeners to extension directory (#24248)
  mobile: build Swift with whole module optimization (#24396)
  ci: update `actions/setup-java` from v1 to v3.8 (#24393)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
jwendell pushed a commit to jwendell/envoy that referenced this pull request Dec 22, 2022
This reverts commit dede92e. Originally
this was reverted because of envoyproxy#23985
Signed-off-by: Jonh Wendell <jwendell@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants