Ecds config dump recommit#24384
Conversation
…verted by (envoyproxy#24354) This reverts commit c5d6160. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…ment lines. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/assign @adisuissa @kyessenov @yanavlasov @alyssawilk |
alyssawilk
assigned
alyssawilk,
yanavlasov and
kyessenov and unassigned
adisuissa,
yanavlasov,
kyessenov and
alyssawilk
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
/lgtm api
Removing lines of comments to fix coverage seems to be the wrong thing to do, so I'd personally say that reducing the coverage threshold is better. Leaving it up to the senior maintainers to weigh in.
Other than that, LGTM!
Agreed. I think we should modify the CI scripts to fix this line-coverage counting issue on comments. |
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Coverage looks fine now.
|
Thanks for taking care of the coverage. |
….h-into-multiple-header-files * origin/main: Add setRequestDecoder to ResponseEncoder interface (#24368) downstream: refactoring code to remove listener hard deps (#24394) lb api: moving load balancing policy specific configuration to extension configuration (#23967) ci: Skip docker/examples verification for docs or mobile only changes (#24417) ci: run mobile GitHub Actions on every PR (#24407) mobile: remove `bump_lyft_support_rotation.sh` script (#24404) Add file size to DirectoryEntry (#24176) bazel: update to 6.0.0rc4 (#24235) bazel: update rules_rust (#24409) Ecds config dump recommit (#24384) bazel: add another config_setting incompatible flag (#24270) listeners: moving listeners to extension directory (#24248) mobile: build Swift with whole module optimization (#24396) ci: update `actions/setup-java` from v1 to v3.8 (#24393) Signed-off-by: JP Simard <jp@jpsim.com>
Thanks for approval! |
…-cpp-to-latest-version * origin/main: (23 commits) Reduce Route memory utilization by avoiding RuntimeData instances when not needed (#24327) build: fix compile error for mac (#24429) postgres: support for upstream SSL (#23990) iOS: split `EnvoyEngine.h` into multiple header files (#24397) mobile: check for pending exceptions after JNI call (#24361) Remove uneccessary `this->` from mobile engine builder (#24389) Add setRequestDecoder to ResponseEncoder interface (#24368) downstream: refactoring code to remove listener hard deps (#24394) lb api: moving load balancing policy specific configuration to extension configuration (#23967) ci: Skip docker/examples verification for docs or mobile only changes (#24417) ci: run mobile GitHub Actions on every PR (#24407) mobile: remove `bump_lyft_support_rotation.sh` script (#24404) Add file size to DirectoryEntry (#24176) bazel: update to 6.0.0rc4 (#24235) bazel: update rules_rust (#24409) Ecds config dump recommit (#24384) bazel: add another config_setting incompatible flag (#24270) listeners: moving listeners to extension directory (#24248) mobile: build Swift with whole module optimization (#24396) ci: update `actions/setup-java` from v1 to v3.8 (#24393) ... Signed-off-by: JP Simard <jp@jpsim.com>
5 participants
ECDS config dump is initially committed by #23902 .
#23902 is later on reverted by #24354 due to a few lines of code is not tested #24362.
This PR reverted #24354 to reinstall #23902 also added the changes of #24362 in.
Please check the original code review history of #23902 for details.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]