Revert "Adding ECDS config dump support. (#23902)"#24354
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Dec 5, 2022
Merged
Revert "Adding ECDS config dump support. (#23902)"#24354alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
This reverts commit 3752119.
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
|
@kyessenov It turns out @zirain's issue #20086 is not due to config dump. That issue has been closed. |
yanjunxiang-google
added a commit
to yanjunxiang-google/envoy
that referenced
this pull request
Dec 6, 2022
History: ECDS config dump is first committed by : envoyproxy#23902. There are some tests issues which is fixed by: envoyproxy#24362 This PR is to: revert envoyproxy#24354, at same time add a couple lines added in envoyproxy#24362, to re-commit ECDS config dump functionality. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
added a commit
to yanjunxiang-google/envoy
that referenced
this pull request
Dec 6, 2022
…verted by (envoyproxy#24354) This reverts commit c5d6160. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanavlasov
pushed a commit
that referenced
this pull request
Dec 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was landed without senior maintainer approval and contributed to breaking coverage on main
let's roll back and then roll forward when it has sufficient testing and approvals
Part of https://github.com/envoyproxy/envoy/pull/24354