Fixing ECDS config dump flaky issue.#24362
Closed
yanjunxiang-google wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Fixing ECDS config dump flaky issue.#24362yanjunxiang-google wants to merge 1 commit intoenvoyproxy:mainfrom
yanjunxiang-google wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/assign @alyssawilk @kyessenov |
Contributor
Author
yanjunxiang-google
added a commit
to yanjunxiang-google/envoy
that referenced
this pull request
Dec 6, 2022
History: ECDS config dump is first committed by : envoyproxy#23902. There are some tests issues which is fixed by: envoyproxy#24362 This PR is to: revert envoyproxy#24354, at same time add a couple lines added in envoyproxy#24362, to re-commit ECDS config dump functionality. Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
|
Do you still need this PR after #24384 was merged? If not please close it. |
Contributor
|
/wait-any |
Contributor
Author
Yeah, this PR is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yanjun Xiang yanjunxiang@google.com
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]