Envoy's L7 Go extension API by wangfakang · Pull Request #22573 · envoyproxy/envoy

wangfakang · 2022-08-05T03:25:05Z

This PR is about Envoy's Go extension API , which provides a API for extending Envoy's L7 filter via go. Developers can use the Go to implement filter processing of request or response streams, and the final effect is the same as that of Envoy's native filter, which makes it easier to extend Envoy. The implementation will be pushed after the community agrees on the design and completes the API.

The following describes the interaction between Envoy and the filter implemented with the Go extension API:

@mattklein123 @htuch @lizan @bkgs @tgraf @jrajahalme
Looking forward to your ideas/comments on this PR!

Commit Message: Add API for Envoy's L7 Go extension
Design doc: https://docs.google.com/document/d/1noApyS0IfmOGmEOHdWk2-BOp0V37zgXMM4MdByr1lQk/edit?usp=sharing
Additional Description: #15152
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

sync from master.

syncfrom master.

sync from master.

sync from upstream.

sync from master

sync from master.

sync from master

wangfakang · 2022-12-10T00:39:17Z

@mattklein123 PTAL. Thanks

mattklein123

Thanks this is looking pretty close. 2 other comments:

Add a release note in current.yaml and reference new docs.
Contrib extensions do not have ASAN and TSAN run on them by default. Manually run all the new tests with ASAN and TSAN and post the results. Thank you.

/wait

contrib/golang/filters/http/source/common/dso/dso.cc

contrib/golang/filters/http/source/config.cc

contrib/golang/filters/http/source/golang_filter.cc

contrib/golang/filters/http/test/golang_filter_test.cc

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: sky <fakangwang@gmail.com>

Signed-off-by: wangfakang <fakangwang@gmail.com>

…i-v1

wangfakang · 2022-12-13T14:33:43Z

Thanks this is looking pretty close. 2 other comments:

Add a release note in current.yaml and reference new docs.

Contrib extensions do not have ASAN and TSAN run on them by default. Manually run all the new tests with ASAN and TSAN and post the results. Thank you.

/wait

@mattklein123 Thank you very much for your careful review, which has taught me a lot.
I used clang-asan and clang-tsan to successfully run all the test cases of the go extension. Some results are as below.

ASAN

$bazel test -c fastbuild //contrib/golang/filters/http/test/...  --config=clang-asan --test_verbose_timeout_warnings   --test_env=ENVOY_IP_TEST_VERSIONS=v4only  --verbose_failures  --test_arg="-l debug"  --define=wasm=disabled
DEBUG: /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/external/rules_python/python/pip.bzl:46:10: pip_install is deprecated. Please switch to pip_parse. pip_install will be removed in a future release.
INFO: Analyzed 9 targets (0 packages loaded, 0 targets configured).
INFO: Found 5 targets and 4 test targets...
INFO: From Executing genrule @io_opentracing_cpp//:generate_version_h:
-- The C compiler identification is Clang 11.0.0
-- The CXX compiler identification is Clang 11.0.0
-- Check for working C compiler: /usr/local/bin/clang
-- Check for working C compiler: /usr/local/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/local/bin/clang++
-- Check for working CXX compiler: /usr/local/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- clang-tidy not found.
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.9MvmbsVAFz
-- Cache values
BUILD_DYNAMIC_LOADING:BOOL=ON
BUILD_MOCKTRACER:BOOL=OFF
BUILD_SHARED_LIBS:BOOL=ON
BUILD_STATIC_LIBS:BOOL=ON
BUILD_TESTING:BOOL=OFF
CLANG_TIDY_EXE:FILEPATH=CLANG_TIDY_EXE-NOTFOUND
CMAKE_BUILD_TYPE:STRING=
CMAKE_INSTALL_PREFIX:PATH=/usr/local
ENABLE_LINTING:BOOL=ON
INFO: From Generating proto_library @com_google_googleapis//google/devtools/cloudtrace/v2:cloudtrace_proto:
google/devtools/cloudtrace/v2/trace.proto:19:1: warning: Import google/api/annotations.proto is unused.
google/devtools/cloudtrace/v2/tracing.proto:26:1: warning: Import google/protobuf/timestamp.proto is unused.
INFO: From Compiling eval/public/structs/protobuf_descriptor_type_provider.cc:
In file included from external/com_google_cel_cpp/eval/public/structs/protobuf_descriptor_type_provider.cc:15:
external/com_google_cel_cpp/eval/public/structs/protobuf_descriptor_type_provider.h:53:27: warning: private field 'unboxing_option_' is not used [-Wunused-private-field]
  ProtoWrapperTypeOptions unboxing_option_;
                          ^
1 warning generated.
INFO: From Action external/opencensus_proto/opencensus/proto/agent/trace/v1/trace_service.grpc.pb.h:
bazel-out/k8-fastbuild/bin/external/opencensus_proto/external/opencensus_proto: warning: directory does not exist.
INFO: From Action external/com_google_googleapis/google/devtools/cloudtrace/v2/trace.grpc.pb.h:
bazel-out/k8-fastbuild/bin/external/com_google_googleapis/external/com_google_googleapis: warning: directory does not exist.
google/devtools/cloudtrace/v2/trace.proto:19:1: warning: Import google/api/annotations.proto is unused.
google/devtools/cloudtrace/v2/tracing.proto:26:1: warning: Import google/protobuf/timestamp.proto is unused.
INFO: Elapsed time: 2716.501s, Critical Path: 351.98s
INFO: 4591 processes: 1559 internal, 3032 linux-sandbox.
INFO: Build completed successfully, 4591 total actions

Executed 4 out of 4 tests: 4 tests pass.

TSAN

$bazel test -c fastbuild //contrib/golang/filters/http/test/...   --config=clang-tsan --test_verbose_timeout_warnings   --test_env=ENVOY_IP_TEST_VERSIONS=v4only --verbose_failures  --config=gcc  --test_arg="-l debug"  --define=wasm=disabled --build_tests_only
Starting local Bazel server and connecting to it...
WARNING: option '--build_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
WARNING: option '--test_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
DEBUG: /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/external/rules_python/python/pip.bzl:46:10: pip_install is deprecated. Please switch to pip_parse. pip_install will be removed in a future release.
WARNING: option '--build_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
WARNING: option '--test_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
INFO: Analyzed 4 targets (930 packages loaded, 32893 targets configured).
INFO: Found 4 test targets...
INFO: Deleting stale sandbox base /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/sandbox
INFO: Elapsed time: 566.694s, Critical Path: 471.52s
INFO: 22 processes: 1 internal, 21 linux-sandbox.
INFO: Build completed successfully, 22 total actions

Executed 3 out of 4 tests: 4 tests pass.

mattklein123

/wait

contrib/golang/filters/http/source/common/dso/dso.cc

contrib/golang/filters/http/source/golang_filter.cc

contrib/golang/filters/http/source/config.cc

Signed-off-by: wangfakang <fakangwang@gmail.com>

…i-v1

wangfakang · 2022-12-13T23:39:05Z

/retest

repokitteh-read-only · 2022-12-13T23:39:14Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22573 (comment) was created by @wangfakang.

see: more, trace.

mattklein123

/wait

contrib/golang/filters/http/source/golang_filter.cc

Signed-off-by: wangfakang <fakangwang@gmail.com>

…i-v1

wangfakang · 2022-12-15T13:40:18Z

/retest

repokitteh-read-only · 2022-12-15T13:40:28Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22573 (comment) was created by @wangfakang.

see: more, trace.

wangfakang · 2022-12-16T15:03:23Z

Thanks this is looking pretty close. 2 other comments:

Add a release note in current.yaml and reference new docs.

Contrib extensions do not have ASAN and TSAN run on them by default. Manually run all the new tests with ASAN and TSAN and post the results. Thank you.

/wait

@mattklein123 Thank you very much for your careful review, which has taught me a lot. I used clang-asan and clang-tsan to successfully run all the test cases of the go extension. Some results are as below.

ASAN

$bazel test -c fastbuild //contrib/golang/filters/http/test/...  --config=clang-asan --test_verbose_timeout_warnings   --test_env=ENVOY_IP_TEST_VERSIONS=v4only  --verbose_failures  --test_arg="-l debug"  --define=wasm=disabled
DEBUG: /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/external/rules_python/python/pip.bzl:46:10: pip_install is deprecated. Please switch to pip_parse. pip_install will be removed in a future release.
INFO: Analyzed 9 targets (0 packages loaded, 0 targets configured).
INFO: Found 5 targets and 4 test targets...
INFO: From Executing genrule @io_opentracing_cpp//:generate_version_h:
-- The C compiler identification is Clang 11.0.0
-- The CXX compiler identification is Clang 11.0.0
-- Check for working C compiler: /usr/local/bin/clang
-- Check for working C compiler: /usr/local/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/local/bin/clang++
-- Check for working CXX compiler: /usr/local/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- clang-tidy not found.
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.9MvmbsVAFz
-- Cache values
BUILD_DYNAMIC_LOADING:BOOL=ON
BUILD_MOCKTRACER:BOOL=OFF
BUILD_SHARED_LIBS:BOOL=ON
BUILD_STATIC_LIBS:BOOL=ON
BUILD_TESTING:BOOL=OFF
CLANG_TIDY_EXE:FILEPATH=CLANG_TIDY_EXE-NOTFOUND
CMAKE_BUILD_TYPE:STRING=
CMAKE_INSTALL_PREFIX:PATH=/usr/local
ENABLE_LINTING:BOOL=ON
INFO: From Generating proto_library @com_google_googleapis//google/devtools/cloudtrace/v2:cloudtrace_proto:
google/devtools/cloudtrace/v2/trace.proto:19:1: warning: Import google/api/annotations.proto is unused.
google/devtools/cloudtrace/v2/tracing.proto:26:1: warning: Import google/protobuf/timestamp.proto is unused.
INFO: From Compiling eval/public/structs/protobuf_descriptor_type_provider.cc:
In file included from external/com_google_cel_cpp/eval/public/structs/protobuf_descriptor_type_provider.cc:15:
external/com_google_cel_cpp/eval/public/structs/protobuf_descriptor_type_provider.h:53:27: warning: private field 'unboxing_option_' is not used [-Wunused-private-field]
  ProtoWrapperTypeOptions unboxing_option_;
                          ^
1 warning generated.
INFO: From Action external/opencensus_proto/opencensus/proto/agent/trace/v1/trace_service.grpc.pb.h:
bazel-out/k8-fastbuild/bin/external/opencensus_proto/external/opencensus_proto: warning: directory does not exist.
INFO: From Action external/com_google_googleapis/google/devtools/cloudtrace/v2/trace.grpc.pb.h:
bazel-out/k8-fastbuild/bin/external/com_google_googleapis/external/com_google_googleapis: warning: directory does not exist.
google/devtools/cloudtrace/v2/trace.proto:19:1: warning: Import google/api/annotations.proto is unused.
google/devtools/cloudtrace/v2/tracing.proto:26:1: warning: Import google/protobuf/timestamp.proto is unused.
INFO: Elapsed time: 2716.501s, Critical Path: 351.98s
INFO: 4591 processes: 1559 internal, 3032 linux-sandbox.
INFO: Build completed successfully, 4591 total actions

Executed 4 out of 4 tests: 4 tests pass.

TSAN

$bazel test -c fastbuild //contrib/golang/filters/http/test/...   --config=clang-tsan --test_verbose_timeout_warnings   --test_env=ENVOY_IP_TEST_VERSIONS=v4only --verbose_failures  --config=gcc  --test_arg="-l debug"  --define=wasm=disabled --build_tests_only
Starting local Bazel server and connecting to it...
WARNING: option '--build_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
WARNING: option '--test_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
DEBUG: /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/external/rules_python/python/pip.bzl:46:10: pip_install is deprecated. Please switch to pip_parse. pip_install will be removed in a future release.
WARNING: option '--build_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
WARNING: option '--test_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
INFO: Analyzed 4 targets (930 packages loaded, 32893 targets configured).
INFO: Found 4 test targets...
INFO: Deleting stale sandbox base /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/sandbox
INFO: Elapsed time: 566.694s, Critical Path: 471.52s
INFO: 22 processes: 1 internal, 21 linux-sandbox.
INFO: Build completed successfully, 22 total actions

Executed 3 out of 4 tests: 4 tests pass.

@mattklein123 PTAL. Thanks

wangfakang · 2022-12-19T11:01:55Z

Thanks this is looking pretty close. 2 other comments:

Add a release note in current.yaml and reference new docs.

Contrib extensions do not have ASAN and TSAN run on them by default. Manually run all the new tests with ASAN and TSAN and post the results. Thank you.

/wait

@mattklein123 Thank you very much for your careful review, which has taught me a lot. I used clang-asan and clang-tsan to successfully run all the test cases of the go extension. Some results are as below.

ASAN

$bazel test -c fastbuild //contrib/golang/filters/http/test/...  --config=clang-asan --test_verbose_timeout_warnings   --test_env=ENVOY_IP_TEST_VERSIONS=v4only  --verbose_failures  --test_arg="-l debug"  --define=wasm=disabled
DEBUG: /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/external/rules_python/python/pip.bzl:46:10: pip_install is deprecated. Please switch to pip_parse. pip_install will be removed in a future release.
INFO: Analyzed 9 targets (0 packages loaded, 0 targets configured).
INFO: Found 5 targets and 4 test targets...
INFO: From Executing genrule @io_opentracing_cpp//:generate_version_h:
-- The C compiler identification is Clang 11.0.0
-- The CXX compiler identification is Clang 11.0.0
-- Check for working C compiler: /usr/local/bin/clang
-- Check for working C compiler: /usr/local/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/local/bin/clang++
-- Check for working CXX compiler: /usr/local/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- clang-tidy not found.
-- Configuring done
-- Generating done
-- Build files have been written to: /tmp/tmp.9MvmbsVAFz
-- Cache values
BUILD_DYNAMIC_LOADING:BOOL=ON
BUILD_MOCKTRACER:BOOL=OFF
BUILD_SHARED_LIBS:BOOL=ON
BUILD_STATIC_LIBS:BOOL=ON
BUILD_TESTING:BOOL=OFF
CLANG_TIDY_EXE:FILEPATH=CLANG_TIDY_EXE-NOTFOUND
CMAKE_BUILD_TYPE:STRING=
CMAKE_INSTALL_PREFIX:PATH=/usr/local
ENABLE_LINTING:BOOL=ON
INFO: From Generating proto_library @com_google_googleapis//google/devtools/cloudtrace/v2:cloudtrace_proto:
google/devtools/cloudtrace/v2/trace.proto:19:1: warning: Import google/api/annotations.proto is unused.
google/devtools/cloudtrace/v2/tracing.proto:26:1: warning: Import google/protobuf/timestamp.proto is unused.
INFO: From Compiling eval/public/structs/protobuf_descriptor_type_provider.cc:
In file included from external/com_google_cel_cpp/eval/public/structs/protobuf_descriptor_type_provider.cc:15:
external/com_google_cel_cpp/eval/public/structs/protobuf_descriptor_type_provider.h:53:27: warning: private field 'unboxing_option_' is not used [-Wunused-private-field]
  ProtoWrapperTypeOptions unboxing_option_;
                          ^
1 warning generated.
INFO: From Action external/opencensus_proto/opencensus/proto/agent/trace/v1/trace_service.grpc.pb.h:
bazel-out/k8-fastbuild/bin/external/opencensus_proto/external/opencensus_proto: warning: directory does not exist.
INFO: From Action external/com_google_googleapis/google/devtools/cloudtrace/v2/trace.grpc.pb.h:
bazel-out/k8-fastbuild/bin/external/com_google_googleapis/external/com_google_googleapis: warning: directory does not exist.
google/devtools/cloudtrace/v2/trace.proto:19:1: warning: Import google/api/annotations.proto is unused.
google/devtools/cloudtrace/v2/tracing.proto:26:1: warning: Import google/protobuf/timestamp.proto is unused.
INFO: Elapsed time: 2716.501s, Critical Path: 351.98s
INFO: 4591 processes: 1559 internal, 3032 linux-sandbox.
INFO: Build completed successfully, 4591 total actions

Executed 4 out of 4 tests: 4 tests pass.

TSAN

$bazel test -c fastbuild //contrib/golang/filters/http/test/...   --config=clang-tsan --test_verbose_timeout_warnings   --test_env=ENVOY_IP_TEST_VERSIONS=v4only --verbose_failures  --config=gcc  --test_arg="-l debug"  --define=wasm=disabled --build_tests_only
Starting local Bazel server and connecting to it...
WARNING: option '--build_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
WARNING: option '--test_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
DEBUG: /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/external/rules_python/python/pip.bzl:46:10: pip_install is deprecated. Please switch to pip_parse. pip_install will be removed in a future release.
WARNING: option '--build_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
WARNING: option '--test_tag_filters' was expanded to from both option '--config=clang-tsan' (source command line options) and option '--config=clang-tsan' (source command line options)
INFO: Analyzed 4 targets (930 packages loaded, 32893 targets configured).
INFO: Found 4 test targets...
INFO: Deleting stale sandbox base /home/fakang.wfk/.cache/bazel/_bazel_fakang.wfk/05ab2d40a050525b20b2187bf5222296/sandbox
INFO: Elapsed time: 566.694s, Critical Path: 471.52s
INFO: 22 processes: 1 internal, 21 linux-sandbox.
INFO: Build completed successfully, 22 total actions

Executed 3 out of 4 tests: 4 tests pass.

@mattklein123 Thanks for your comments, all of them are addressed. Thanks

mattklein123

/wait

contrib/golang/filters/http/source/common/dso/dso.h

contrib/golang/filters/http/source/golang_filter.h

Signed-off-by: wangfakang <fakangwang@gmail.com>

mattklein123

Thanks, LGTM to ship and iterate! Cool stuff.

wangfakang added 30 commits April 22, 2020 14:50

Merge pull request #1 from envoyproxy/master

7a45ea5

sync from master.

Merge pull request #2 from envoyproxy/master

1335354

sync from master.

Merge pull request #3 from envoyproxy/master

446c4b1

sync from master.

Merge pull request #4 from envoyproxy/master

8e7d66a

sync from master.

Merge pull request #5 from envoyproxy/master

7d72ab9

sync from master.

Merge pull request #6 from envoyproxy/master

dd0dba9

sync from master.

Merge pull request #7 from envoyproxy/main

091fd77

sync from master.

Merge pull request #8 from envoyproxy/main

d9dcf64

sync from master.

Merge pull request #9 from envoyproxy/main

95c509b

sync from master.

Merge pull request #20 from envoyproxy/main

1c5859a

sync from master.

Merge pull request #59 from envoyproxy/main

e272f6a

sync from master.

Merge pull request #71 from envoyproxy/main

0f77a38

sync from master.

Merge pull request #72 from envoyproxy/main

d05e4cf

sync from master.

Merge pull request #74 from envoyproxy/main

023d3a9

sync from master.

Merge pull request #83 from envoyproxy/main

d091174

sync from master.

Merge pull request #93 from envoyproxy/main

4c88aad

syncfrom master.

Merge pull request #97 from envoyproxy/main

1d788fe

sync from master.

Merge branch 'envoyproxy:main' into master

4c68eb0

Merge pull request #108 from envoyproxy/main

4dc847b

sync from master.

Merge pull request #117 from envoyproxy/main

1a620b6

sync from master.

Merge branch 'envoyproxy:main' into master

4bd041e

Merge pull request #133 from envoyproxy/main

5318196

sync from master.

Merge pull request #154 from envoyproxy/main

88d279f

sync from upstream.

Merge pull request #166 from envoyproxy/main

0c677c3

sync from master

Merge pull request #169 from envoyproxy/main

23a9ba3

sync from master

Merge pull request #170 from envoyproxy/main

ce02fd8

sync from master.

Merge pull request #194 from envoyproxy/main

755b023

sync from master.

Merge pull request #216 from envoyproxy/main

df47643

sync from master

Merge pull request #229 from envoyproxy/main

0886f78

sync from master

Merge pull request #237 from envoyproxy/main

6bb0267

sync from master

mattklein123 requested changes Dec 12, 2022

View reviewed changes

wangfakang and others added 5 commits December 13, 2022 14:28

Update contrib/golang/filters/http/source/golang_filter.cc

659e4a0

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: sky <fakangwang@gmail.com>

make code clear and update log level. thanks @mattklein123

0060264

Signed-off-by: wangfakang <fakangwang@gmail.com>

update current.yaml for golang extension.

13766aa

Signed-off-by: wangfakang <fakangwang@gmail.com>

Merge branch 'envoyproxy:main' into master

b444671

Merge remote-tracking branch 'origin/master' into golang-extension-ap…

95e9a1a

…i-v1

mattklein123 requested changes Dec 13, 2022

View reviewed changes

contrib/golang/filters/http/source/common/dso/dso.cc Outdated Show resolved Hide resolved

contrib/golang/filters/http/source/golang_filter.cc Outdated Show resolved Hide resolved

contrib/golang/filters/http/source/config.cc Show resolved Hide resolved

wangfakang added 3 commits December 14, 2022 01:33

Merge branch 'envoyproxy:main' into master

eb4d845

make code clear and update log level to debug. thanks @mattklein123

d047583

Signed-off-by: wangfakang <fakangwang@gmail.com>

Merge remote-tracking branch 'origin/master' into golang-extension-ap…

91243de

…i-v1

mattklein123 requested changes Dec 14, 2022

View reviewed changes

contrib/golang/filters/http/source/golang_filter.cc Show resolved Hide resolved

wangfakang added 3 commits December 15, 2022 19:45

Merge branch 'envoyproxy:main' into master

cb4c14b

use assert to make the code clearer. thanks @mattklein123

7b8a618

Signed-off-by: wangfakang <fakangwang@gmail.com>

Merge remote-tracking branch 'origin/master' into golang-extension-ap…

1a12ad8

…i-v1

doujiang24 mentioned this pull request Dec 18, 2022

Roadmap to add more features? mosn/envoy-go-extension#48

Open

12 tasks

mattklein123 requested changes Jan 3, 2023

View reviewed changes

contrib/golang/filters/http/source/common/dso/dso.h Outdated Show resolved Hide resolved

contrib/golang/filters/http/source/golang_filter.h Outdated Show resolved Hide resolved

remove all unused code. thanks @mattklein123

6dbdb3a

Signed-off-by: wangfakang <fakangwang@gmail.com>

mattklein123 approved these changes Jan 5, 2023

View reviewed changes

izturn mentioned this pull request Jan 6, 2023

Exploration: WASM in Contour projectcontour/contour#4276

Closed

5 tasks

This was referenced Jan 30, 2023

feat: add headerMapImpl.Values to return multiple headers mosn/envoy-go-extension#50

Merged

Implement Add method for header mosn/envoy-go-extension#56

Merged

antJack mentioned this pull request Mar 3, 2023

Envoy's L4 Golang extension #25906

Open

Conversation

wangfakang commented Aug 5, 2022

Uh oh!

wangfakang commented Dec 10, 2022

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangfakang commented Dec 13, 2022

ASAN

TSAN

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wangfakang commented Dec 13, 2022

Uh oh!

repokitteh-read-only bot commented Dec 13, 2022

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wangfakang commented Dec 15, 2022

Uh oh!

repokitteh-read-only bot commented Dec 15, 2022

Uh oh!

wangfakang commented Dec 16, 2022

ASAN

TSAN

Uh oh!

wangfakang commented Dec 19, 2022

ASAN

TSAN

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants