Revert "Revert "bazel: update DEPS on googleurl (#17794)" (#17958)"

[buildbreaker]

This reverts commit 338a42c.

The original PR which this is intending to replicate is: #17794

The original failure which prompted the revert is:

In file included from external/com_googlesource_googleurl/base/strings/string_util.cc:5:
In file included from external/com_googlesource_googleurl/base/strings/string_util.h:22:
In file included from external/com_googlesource_googleurl/base/containers/span.h:18:
external/com_googlesource_googleurl/base/containers/checked_iterators.h:241:8: error: explicit specialization of undeclared template struct '__is_cpp17_contiguous_iterator'
struct __is_cpp17_contiguous_iterator<::gurl_base::CheckedContiguousIterator<T>>
       ^                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Envoy Slack thread context: https://envoyproxy.slack.com/archives/CKQ2LK23G/p1630533652001900

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Alan Chiu achiu@lyft.com

[repokitteh-read-only]

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #18192 was opened by buildbreaker.

see: more, trace.

[repokitteh-read-only]

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18192 was opened by buildbreaker.

see: more, trace.

[buildbreaker]

Deleted. Only difference between #17958

[mattklein123]

Any more info on this deletion? What impact does it have / are we tracking fixing this upstream somehow?

[keith]

It fixes it since the android error is trying to specialize something that doesn't exist. I'm surprise this builds at all though, maybe it's just a performance optimization?

[wrowe]

I'm sorry, but I can't understand the purpose of this request unless @mattklein123 's patch is somehow wrong. Duplicate PR asks do not move issues forward but do lead to good contributors being ignored. Could you please explain?

[mattklein123]

I'm sorry, but I can't understand the purpose of this request unless @mattklein123 's patch is somehow wrong. Duplicate PR asks do not move issues forward but do lead to good contributors being ignored. Could you please explain?

We can't merge the other PR because it's broken on Android. This is an attempt to fix the Android issue.

[buildbreaker]

@wrowe @mattklein123 Correct. Envoy Mobile is looking to update the googleurl to avoid an iOS build issue with an xcode update. The main issue with the update is that the method __is_cpp17_contiguous_iterator is not available in some NDK versions which Envoy Mobile builds against. The main reason for the deletion (might not be the right solution) is to ensure this builds with Envoy (I've tested this locally with Envoy Mobile).

Sorry if I opened this PR prematurely. I was hoping to collaborate more closely with @keith on this issue. He suggested that maybe that method is not necessarily used in Envoy (it builds in Envoy Mobile fwiw).

[keith]

Does this change work on Android? Kinda surprised deleting this would work at all, since I assume they had to do this for a reason 🤔 I think the alternative here is you define a no-op struct, maybe only on android, for this.

[buildbreaker]

I've tested this and this does build with Android in Envoy Mobile. I was hoping to add some #ifdefs instead but it seems like the args aren't passed all the way through for some reason. That's why I went with a straight deletion to verify with Envoy Mobile. I put up this PR as a check to see if Envoy CI would pass

[dio]

/retest

[repokitteh-read-only]

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18192 (comment) was created by @dio.

see: more, trace.