Revert "bazel: update DEPS on googleurl"#17957
Closed
RenjieTang wants to merge 1 commit intoenvoyproxy:mainfrom
Closed
Revert "bazel: update DEPS on googleurl"#17957RenjieTang wants to merge 1 commit intoenvoyproxy:mainfrom
RenjieTang wants to merge 1 commit intoenvoyproxy:mainfrom
Conversation
This reverts commit c76c951.
Contributor
|
Please fix DCO and I'll expedite. Drat. |
Contributor
|
We've had multiple merge and reversions with Do we or is there any way to surface these breakages as part of normal CI and before PRs get merged? /cc @junr03 |
Contributor
|
Alternate possibility, does it make sense to anchor envoy-mobile to the prior working commit of envoy, and work the issues locally on an envoy-mobile branch? |
Contributor
Author
|
I'm having trouble pulling this PR to my local machine. So I created #17958 to fix the DCO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #17794
This broke Envoy-mobile's Android CI: https://github.com/envoyproxy/envoy-mobile/pull/1776/checks?check_run_id=3487183404#step:7:105