Skip to content

Increase common/common coverage#17193

Merged
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
davinci26:increaseCoverage
Jul 1, 2021
Merged

Increase common/common coverage#17193
alyssawilk merged 2 commits intoenvoyproxy:mainfrom
davinci26:increaseCoverage

Conversation

@davinci26
Copy link
Copy Markdown
Member

Increase common/common coverage by:

  1. Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher #17061
  2. Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
@davinci26 davinci26 requested a review from alyssawilk June 29, 2021 23:23
@davinci26
Copy link
Copy Markdown
Member Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17193 (comment) was created by @davinci26.

see: more, trace.

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for both the addition and the removal :-)

@alyssawilk alyssawilk merged commit 7da9989 into envoyproxy:main Jul 1, 2021
baojr added a commit to baojr/envoy that referenced this pull request Jul 1, 2021
* main: (51 commits)
  listener: add filter chain match support for direct source address (envoyproxy#17118)
  Increase common/common coverage (envoyproxy#17193)
  crash_dump: Added local_end_stream_ to crash dump for H2. (envoyproxy#17199)
  codeql: improve Ubuntu dependency installation (envoyproxy#16556)
  ci: Move tooling tests to tooling job (envoyproxy#17071)
  Fix issue with Windows container image (envoyproxy#17113)
  fix filter linking urls (envoyproxy#17185)
  bug fix: fix bug that check_format.py will check files which are ignored (envoyproxy#17195)
  tls: moving the server name into SocketAddressProvider (envoyproxy#16574)
  network: Use std::make_unique and std::make_shared in source/common/network instead of bare new() (envoyproxy#17177)
  Revert "alpha matching: support generic action factory context (envoyproxy#17025)" (envoyproxy#17191)
  ci: Dont clone filter example where not required (envoyproxy#17182)
  alpha matching: support generic action factory context (envoyproxy#17025)
  xds: Clarify comment for RouteMatch.case_sensitive field. (envoyproxy#17176)
  ci: Only publish the required docker image (envoyproxy#17080)
  coverage: fixing flake (envoyproxy#17190)
  api: add cluster_specifier_plugin to RouteAction (envoyproxy#16944)
  wasm: update V8 to v9.2.230.13. (envoyproxy#17183)
  wasm: update Proxy-Wasm C++ Host and SDK to latest (2021-06-24). (envoyproxy#17174)
  owners: add Piotr as senior extension maintainer (envoyproxy#17175)
  ...

Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher envoyproxy#17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Increase common/common coverage by:

Removing CompiledStdMatcher partially cleaned by regex: remove parseStdRegexAsCompiledMatcher envoyproxy#17061
Add test for ContainsReference in stl_helpers

Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants