Conversation
yuval-k
commented
Jul 20, 2021
yuval-k
commented
- fix include path in build files
- fix include path in build files
|
parseStdRegexAsCompiledMatcher was removed from upstream, copy pasted it here. see: |
|
CompiledStdMatcher was removed here: |
| @@ -0,0 +1,6 @@ | |||
| changelog: | |||
There was a problem hiding this comment.
Noticing that the changelog bot is failing. Should this be released as 1.19.0 instead of 1.19.0-patch1?
There was a problem hiding this comment.
i think our release name should be patch1 if envoy already released. to indicate that this is based on a released envoy 1.19.0. the reason we don't just use 1.19.0 is that we may have multiple releases based on 1.19.0
@EItanya - i thought we documented this but i cant find where
| repository = "@envoy", | ||
| deps = [ | ||
| ":aws_lambda_filter_lib", | ||
| "@envoy//include/envoy/registry", |
There was a problem hiding this comment.
Am I correct in understanding that we don't need the registry dep anymore which is why it's removed here (and a few other places)?
There was a problem hiding this comment.
we might need it, i removed it because i thought the path changed; it turned out that it didnt. i think it still works because it is included transitivly
2 participants
