ci: Publish artefacts for the exactly required docker images#17080
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Jun 29, 2021
Merged
ci: Publish artefacts for the exactly required docker images#17080phlax merged 1 commit intoenvoyproxy:mainfrom
phlax merged 1 commit intoenvoyproxy:mainfrom
Conversation
phlax
changed the title
phlax
changed the title
phlax
force-pushed
the
docker-only-save-dev
branch
from
938031d to
4e5894a
Compare
lizan
reviewed
Jun 24, 2021
Member
lizan
left a comment
lizan
left a comment
There was a problem hiding this comment.
What's the purpose of only saving one image instead of all?
Member
Author
|
setting this WIP temporarily - i just realized that envoy-alpine-dev is still required for examples... |
phlax
changed the title
Member
Author
it takes ~20-30 minutes off of the windows docker stage, and ~10 minutes off of the linux docker and verify stages |
phlax
force-pushed
the
docker-only-save-dev
branch
from
4e5894a to
0017dcf
Compare
phlax
changed the title
Member
Author
|
@lizan both issues - alpine and release builds - addressed, ptal - it would be great to land this as it will save a fair amount of ci time/load |
phlax
force-pushed
the
docker-only-save-dev
branch
from
0017dcf to
d4620d9
Compare
Member
Author
phlax
changed the title
phlax
changed the title
Member
Author
|
i just looked at the setec repo and realised 2 things - that also tests the wrong images - ie pulls from dockerhub, and this pr doesnt handle that correctly - ill update... |
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
docker-only-save-dev
branch
from
2891628 to
d0cc7b4
Compare
phlax
changed the title
Member
Author
|
i think this should work now in the required contexts, fix the verify image mismatches and speedup ci all round |
This was referenced Jun 25, 2021
lizan
reviewed
Jun 28, 2021
lizan
approved these changes
Jun 29, 2021
This was referenced Jun 30, 2021
Merged
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jul 1, 2021
* main: (51 commits) listener: add filter chain match support for direct source address (envoyproxy#17118) Increase common/common coverage (envoyproxy#17193) crash_dump: Added local_end_stream_ to crash dump for H2. (envoyproxy#17199) codeql: improve Ubuntu dependency installation (envoyproxy#16556) ci: Move tooling tests to tooling job (envoyproxy#17071) Fix issue with Windows container image (envoyproxy#17113) fix filter linking urls (envoyproxy#17185) bug fix: fix bug that check_format.py will check files which are ignored (envoyproxy#17195) tls: moving the server name into SocketAddressProvider (envoyproxy#16574) network: Use std::make_unique and std::make_shared in source/common/network instead of bare new() (envoyproxy#17177) Revert "alpha matching: support generic action factory context (envoyproxy#17025)" (envoyproxy#17191) ci: Dont clone filter example where not required (envoyproxy#17182) alpha matching: support generic action factory context (envoyproxy#17025) xds: Clarify comment for RouteMatch.case_sensitive field. (envoyproxy#17176) ci: Only publish the required docker image (envoyproxy#17080) coverage: fixing flake (envoyproxy#17190) api: add cluster_specifier_plugin to RouteAction (envoyproxy#16944) wasm: update V8 to v9.2.230.13. (envoyproxy#17183) wasm: update Proxy-Wasm C++ Host and SDK to latest (2021-06-24). (envoyproxy#17174) owners: add Piotr as senior extension maintainer (envoyproxy#17175) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: ci: Only publish the required docker image
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #17132
[Optional Deprecated:]
[Optional API Considerations:]