ci: Move tooling tests to tooling job#17071
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom Jun 30, 2021
Merged
Conversation
phlax
force-pushed
the
ci-format-tests
branch
2 times, most recently
from
b4d56ec to
8af0e8c
Compare
phlax
changed the title
Member
Author
|
marking this wip while i figure out what impact separating the tests has on build times |
phlax
force-pushed
the
ci-format-tests
branch
4 times, most recently
from
a9942bf to
06d8878
Compare
phlax
changed the title
phlax
changed the title
phlax
changed the title
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
Contributor
|
Throwing this over to Lizan becasue I trust him to catch mistakes in these scripts better than I will but I AM SO EXCITED FOR THIS CHANGE. yeah, I spent way too much time in format checks.... |
Member
Author
|
@alyssawilk this gives a small speedup in terms of sequential run time but not overall - except in the case where one of these tests fails which currently triggers an rerun of all format jobs mostly, its just another step to unpicking and isolating the non-performant jobs - but its also the better place for these jobs in terms of ci i think |
Member
Author
i just realised you meant running them locally - i never do it - which is part of the reason im trying to separate out the stuff that causes my laptop to spin out - most of the actual format checks can run ~quickly if we remove all of the tooling tests and proto mangling |
lizan
approved these changes
Jun 30, 2021
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jul 1, 2021
* main: (51 commits) listener: add filter chain match support for direct source address (envoyproxy#17118) Increase common/common coverage (envoyproxy#17193) crash_dump: Added local_end_stream_ to crash dump for H2. (envoyproxy#17199) codeql: improve Ubuntu dependency installation (envoyproxy#16556) ci: Move tooling tests to tooling job (envoyproxy#17071) Fix issue with Windows container image (envoyproxy#17113) fix filter linking urls (envoyproxy#17185) bug fix: fix bug that check_format.py will check files which are ignored (envoyproxy#17195) tls: moving the server name into SocketAddressProvider (envoyproxy#16574) network: Use std::make_unique and std::make_shared in source/common/network instead of bare new() (envoyproxy#17177) Revert "alpha matching: support generic action factory context (envoyproxy#17025)" (envoyproxy#17191) ci: Dont clone filter example where not required (envoyproxy#17182) alpha matching: support generic action factory context (envoyproxy#17025) xds: Clarify comment for RouteMatch.case_sensitive field. (envoyproxy#17176) ci: Only publish the required docker image (envoyproxy#17080) coverage: fixing flake (envoyproxy#17190) api: add cluster_specifier_plugin to RouteAction (envoyproxy#16944) wasm: update V8 to v9.2.230.13. (envoyproxy#17183) wasm: update Proxy-Wasm C++ Host and SDK to latest (2021-06-24). (envoyproxy#17174) owners: add Piotr as senior extension maintainer (envoyproxy#17175) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
Moves the format tests to the tooling job - this prevents eg the tests being called repeatedly in fix/test calls, speeds up precheck a bit (by making pre-check jobs more parallel) and will make it easier to optimize these tests Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Moves the format tests to the tooling job - this prevents eg the tests being called repeatedly in fix/test calls, speeds up precheck a bit (by making pre-check jobs more parallel) and will make it easier to optimize these tests Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: ci: Move format tests to tooling
Additional Description:
Moves the format tests to the tooling job - this prevents eg the tests being called repeatedly in fix/test calls, speeds up precheck a bit (by making pre-check jobs more parallel) and will make it easier to optimize these tests
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]