Conversation
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
|
@keith @Augustyniak ptal |
jpsim
left a comment
jpsim
left a comment
There was a problem hiding this comment.
It'd be good to have some tests validating that a buffer can be read and written across the generated language bindings, but not necessary right now. If we start using flatbuffers in EM directly we can add tests for that specifically.
The java version is 2.0.3 but the C++ and Swift versions are 2.0.0. Are those versions compatible with each other?
bazel/flatbuffers.bzl
Outdated
| name = "{}_fb_swift_srcs".format(name), | ||
| srcs = ["test.fbs"], | ||
| outs = [ | ||
| "test_generated.swift", |
There was a problem hiding this comment.
Nit: why test_generated.swift? Can this be $(name).generated.swift?
| "test_generated.swift", | |
| "{}.generated.swift".format(name), |
There was a problem hiding this comment.
Ah yeah the swift rules here aren't generic, just hard coded to the test.fbs input, let me update
|
I would expect them to be compatible per semver, also from looking into the format a bit I believe the underlying binary format is very stable, most changes to the library are around updating the per language bindings. For example, this seems like one of the patch changes: google/flatbuffers#6785 |
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
* main: (59 commits) Bump Lyft Support Rotation (#2156) add specifying more maven deps (#2151) update envoy@e4eaf1b97 (#2146) bazel: create symbol mapping file (#2126) Bump Lyft Support Rotation (#2148) bazel: remove sandbox disable build: export flatbuffer jvm dep (#2147) Bump Lyft Support Rotation (#2143) bazel: Add flatbuffers Swift hack key_value: structure for prefs based key value store (#2120) build: add flatbuffers (#2133) Bump Lyft Support Rotation (#2131) envoy: bump upstream Envoy to 419e237 (#2132) stats: enable more metrics (#2130) Use the right type (envoy_network_t) (#2125) Bump Lyft Support Rotation (#2118) Update CONTRIBUTING.md to include updating subrepos (#2023) ci: create baseline and experimental test app pipelines (#2075) config: temporarily hardcode h2 max concurrent streams to 100 (#2124) ... Signed-off-by: JP Simard <jp@jpsim.com>
4 participants
This adds flatbuffers to the build, including a bzl macro for generating Kotlin/Swift/C++ files for a given flatbuffer file. Tests are added that demonstrate that the platform code can consume these generated files
Signed-off-by: Snow Pettersen snowp@lyft.com
Description:
Risk Level: Low, build only
Testing: New tests
Docs Changes: n/a
Release Notes: n/a