Merged
Conversation
Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com>
jpsim
approved these changes
Mar 28, 2022
jpsim
reviewed
Mar 28, 2022
| google_re2: {} | ||
| regex: '^cluster\.[\w]+?\.upstream_rq_[\w]+' | ||
| - safe_regex: | ||
| google_re2: {} |
Contributor
There was a problem hiding this comment.
Is there ever a situation we'd want to use re2?
Contributor
Author
There was a problem hiding this comment.
Frankly speaking - I do not know. I was an ignorant and followed the established pattern + I'm just more familiar with standard regexes so felt more comfortable doing that.
jpsim
added a commit
that referenced
this pull request
Apr 12, 2022
* main: (59 commits) Bump Lyft Support Rotation (#2156) add specifying more maven deps (#2151) update envoy@e4eaf1b97 (#2146) bazel: create symbol mapping file (#2126) Bump Lyft Support Rotation (#2148) bazel: remove sandbox disable build: export flatbuffer jvm dep (#2147) Bump Lyft Support Rotation (#2143) bazel: Add flatbuffers Swift hack key_value: structure for prefs based key value store (#2120) build: add flatbuffers (#2133) Bump Lyft Support Rotation (#2131) envoy: bump upstream Envoy to 419e237 (#2132) stats: enable more metrics (#2130) Use the right type (envoy_network_t) (#2125) Bump Lyft Support Rotation (#2118) Update CONTRIBUTING.md to include updating subrepos (#2023) ci: create baseline and experimental test app pipelines (#2075) config: temporarily hardcode h2 max concurrent streams to 100 (#2124) ... Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafal Augustyniak raugustyniak@lyft.com
Description: Modify config to enable more metrics. Mainly focused on downstream requests, DNS updates and h2 ping timeouts. The changes add around 44 new metrics (a move from around 250 to around 290).
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A