Skip to content

config: temporarily hardcode h2 max concurrent streams to 100#2124

Merged
Augustyniak merged 1 commit intomainfrom
ms/hardcode-concurrent-streams
Mar 22, 2022
Merged

config: temporarily hardcode h2 max concurrent streams to 100#2124
Augustyniak merged 1 commit intomainfrom
ms/hardcode-concurrent-streams

Conversation

@goaway
Copy link
Contributor

@goaway goaway commented Mar 22, 2022

Description: This plays nicer with some upstreams that have this commonly configured as default because it preemptively allows for local queueing to occur and/or additional connections to be utilized. However we should iterate and consider the following improvements:

  1. make globally configurable
  2. make configurable per-host
  3. remember server settings for next time

Risk: Low
Testing: Local

Signed-off-by: Mike Schore mike.schore@gmail.com

Signed-off-by: Mike Schore <mike.schore@gmail.com>
@goaway
Copy link
Contributor Author

goaway commented Mar 22, 2022

cc @mattklein123

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Augustyniak Augustyniak merged commit 01194a0 into main Mar 22, 2022
@Augustyniak Augustyniak deleted the ms/hardcode-concurrent-streams branch March 22, 2022 22:00
jpsim added a commit that referenced this pull request Apr 12, 2022
* main: (59 commits)
  Bump Lyft Support Rotation (#2156)
  add specifying more maven deps (#2151)
  update envoy@e4eaf1b97 (#2146)
  bazel: create symbol mapping file (#2126)
  Bump Lyft Support Rotation (#2148)
  bazel: remove sandbox disable
  build: export flatbuffer jvm dep (#2147)
  Bump Lyft Support Rotation (#2143)
  bazel: Add flatbuffers Swift hack
  key_value: structure for prefs based key value store (#2120)
  build: add flatbuffers (#2133)
  Bump Lyft Support Rotation (#2131)
  envoy: bump upstream Envoy to 419e237 (#2132)
  stats: enable more metrics (#2130)
  Use the right type (envoy_network_t) (#2125)
  Bump Lyft Support Rotation (#2118)
  Update CONTRIBUTING.md to include updating subrepos (#2023)
  ci: create baseline and experimental test app pipelines (#2075)
  config: temporarily hardcode h2 max concurrent streams to 100 (#2124)
  ...

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants