[swift] Add bazel configuration for Swift#7195
Merged
dbaileychess merged 3 commits intogoogle:masterfrom Mar 30, 2022
keith:ks/swift-add-bazel-configuration-for-swift
Merged
[swift] Add bazel configuration for Swift#7195dbaileychess merged 3 commits intogoogle:masterfrom keith:ks/swift-add-bazel-configuration-for-swift
dbaileychess merged 3 commits intogoogle:masterfrom
keith:ks/swift-add-bazel-configuration-for-swift
Conversation
This change adds a simple bazel BUILD file for consuming the Swift support. This also bumps the platforms bazel repo to fix support for M1s and bazel 5.1+ bazelbuild/bazel#15099 (comment) The rules_swift inclusion here must happen before gRPC to ensure we don't pull in an older version.
Collaborator
|
Hej! thanks for the PR, @keith Would love to know the idea behind it if possible? since the swift lib doesn't really run on bazel, and it runs on a macOS instants to validate the tests on actions. Unless we are missing something, and it would help us make sure the quality of the code is better |
Contributor
Author
With my bazel CI changes here it is being validated by that CI as well. but the intent is to make it easier to include flatbuffers in iOS projects that build with bazel like envoyproxy/envoy-mobile#2133 |
mustiikhalil
approved these changes
Mar 29, 2022
Collaborator
mustiikhalil
left a comment
mustiikhalil
left a comment
There was a problem hiding this comment.
LGTM from a swift point of view, I've tagged another reviewer just to confirm that we are good to go
dbaileychess
approved these changes
Mar 30, 2022
Contributor
Author
|
Thanks! |
mustiikhalil
pushed a commit
to mustiikhalil/flatbuffers
that referenced
this pull request
Apr 6, 2022
* [swift] Add bazel configuration for Swift This change adds a simple bazel BUILD file for consuming the Swift support. This also bumps the platforms bazel repo to fix support for M1s and bazel 5.1+ bazelbuild/bazel#15099 (comment) The rules_swift inclusion here must happen before gRPC to ensure we don't pull in an older version. * Add CC=clang which is a requirement for Swift on Linux * Add Swift to PATH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a simple bazel BUILD file for consuming the Swift
support. This also bumps the platforms bazel repo to fix support for M1s
and bazel 5.1+ bazelbuild/bazel#15099 (comment)
The rules_swift inclusion here must happen before gRPC to ensure we
don't pull in an older version.