Skip to content

stats: enable more metrics #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Augustyniak merged 1 commit into from
Mar 28, 2022
Merged

stats: enable more metrics #2130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion library/common/config/config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,12 @@ stats_sinks: *stats_sinks
- safe_regex:
google_re2: {}
regex: '^cluster\.[\w]+?\.upstream_rq_[\w]+'
- safe_regex:
google_re2: {}
Copy link
Contributor

@jpsim jpsim Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there ever a situation we'd want to use re2?

Copy link
Contributor Author

@Augustyniak Augustyniak Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly speaking - I do not know. I was an ignorant and followed the established pattern + I'm just more familiar with standard regexes so felt more comfortable doing that.

regex: '^cluster\.[\w]+?\.update_(attempt|success|failure)'
- safe_regex:
google_re2: {}
regex: '^cluster\.[\w]+?\.http2.keepalive_timeout'
- safe_regex:
google_re2: {}
regex: '^dns.apple.*'
Expand All @@ -398,7 +404,7 @@ stats_sinks: *stats_sinks
regex: '^http.hcm.decompressor.*'
- safe_regex:
google_re2: {}
regex: '^http.hcm.downstream_rq_(?:[12345]xx|total|completed)'
regex: '^http.hcm.downstream_rq_[\w]+'
- safe_regex:
google_re2: {}
regex: '^pulse.*'
Expand Down