new Macro: appEmberSatisfies(range)#2550
Merged
NullVoxPopuli merged 16 commits intomainfrom Sep 30, 2025
Merged
Conversation
mansona
previously requested changes
Sep 5, 2025
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
I noticed a few things when I had a quick look. I know it's draft but I thought I would share 😂
NullVoxPopuli
force-pushed
the
nvp/app-dependency-satisfies
branch
from
ec938e7 to
7621322
Compare
NullVoxPopuli
dismissed
mansona’s stale review
review was way premature lol
ef4
approved these changes
Sep 30, 2025
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
Co-authored-by: Chris Manson <mansona@users.noreply.github.com>
…m -- this allows configuring teh appRoot to be something custom we create (such as a 'Project')
…t was not declared in the package.json
NullVoxPopuli
force-pushed
the
nvp/app-dependency-satisfies
branch
from
4f6236f to
fff2154
Compare
This was referenced Sep 30, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?:
This library is now a partial-polyfill for RFC#1068 tracked-tools/tracked-built-ins#440
I ran in to an issue where
dependencySatisfieswas always returning false (because the peerDep was not declared). We can't declare the peerDep because then we force all consumers oftracked-built-insto forward the peer. We've already learned that we can't successfully manage a fully correct package.json-declared dep graph. It's been best to just not declare peers, and rely on the resolve algo, as well as the assumption that the host app must provide ember-source.