Skip to content

Embroider router support for ember source less than 4.12#2624

Merged
void-mAlex merged 2 commits intomainfrom
embroider-router-support-for-ember-source-less-than-4.12
Nov 25, 2025
Merged

Embroider router support for ember source less than 4.12#2624
void-mAlex merged 2 commits intomainfrom
embroider-router-support-for-ember-source-less-than-4.12

Conversation

@void-mAlex
Copy link
Copy Markdown
Collaborator

import getOwner from ember application for ember source pre 4.12

Comment thread packages/router/src/index.ts Outdated
@void-mAlex void-mAlex requested a review from mansona November 25, 2025 15:52
Copy link
Copy Markdown
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@void-mAlex void-mAlex added the bug Something isn't working label Nov 25, 2025
@void-mAlex void-mAlex merged commit eea7c07 into main Nov 25, 2025
544 of 547 checks passed
@void-mAlex void-mAlex deleted the embroider-router-support-for-ember-source-less-than-4.12 branch November 25, 2025 16:54
@github-actions github-actions bot mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants