Drop node: prefix on imports in app-ember-satisfies to accomodate node < 16#2571
Merged
NullVoxPopuli merged 8 commits intomainfrom Oct 2, 2025
Merged
Conversation
NullVoxPopuli
changed the title
node: prefix on imports in app-ember-satisfies to accomodate node < 16
NullVoxPopuli
commented
Oct 2, 2025
Collaborator
Author
There was a problem hiding this comment.
Turns out we don't prettier ignore this
NullVoxPopuli
commented
Oct 2, 2025
| import { satisfies, coerce } from 'semver'; | ||
| import error from './error'; | ||
| import { assertArray } from './evaluate-json'; | ||
| import { pathToFileURL } from 'node:url'; |
Collaborator
Author
There was a problem hiding this comment.
So simple. But ugh
driesdl
reviewed
Oct 2, 2025
| node: ['20', '22', '24'] | ||
| os: [ubuntu-latest, 'macos-latest'] # TODO add windows here | ||
| node: ["20", "22", "24"] | ||
| os: [ubuntu-latest, "macos-latest"] # TODO add windows here |
There was a problem hiding this comment.
should ubuntu-latest be between quotes like macos-latest?
Collaborator
Author
There was a problem hiding this comment.
Idk, it appears to not matter somehow
driesdl
approved these changes
Oct 2, 2025
mansona
force-pushed
the
nvp/test-macros-against-oldest-supported-node
branch
from
9c83642 to
beb5926
Compare
ef4
approved these changes
Oct 2, 2025
NullVoxPopuli
deleted the
nvp/test-macros-against-oldest-supported-node
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2570
The PR that added appEmberSatisfies broke folks using super old node versions.
appEmberSatisfies(range)#2550The features that the PR is using:
node:urlnode:modulenode:pathHowever,
node:prefix has been supported since node @ 16 -- and that's not old enough -- as@embroider/macrosdeclares support for node 12+