This library is now a partial-polyfill for RFC#1068#440
This library is now a partial-polyfill for RFC#1068#440NullVoxPopuli merged 4 commits intomasterfrom
Conversation
addon/types/-private/array.d.ts
Outdated
There was a problem hiding this comment.
This library used to be js + .d.ts, and it was migrated to ts.
I've converted it back, because we now have too much dynamism, and we actually want wholly different implementations to be indistinguishable. from each other, which is something declarations are better at supporting than TS-as-Source
NullVoxPopuli
force-pushed
the
nvp/built-in-built-ins
branch
from
93f1e70 to
51cc75a
Compare
NullVoxPopuli
force-pushed
the
nvp/built-in-built-ins
branch
2 times, most recently
from
cc1724e to
a897457
Compare
| "@babel/plugin-transform-typescript": "^7.24.4", | ||
| "@babel/runtime": "^7.26.10", | ||
| "@embroider/addon-dev": "^4.3.1", | ||
| "@embroider/macros": "^1.19.5", |
There was a problem hiding this comment.
devDep needed for types
NullVoxPopuli
force-pushed
the
nvp/built-in-built-ins
branch
from
36643e0 to
c305d15
Compare
There was a problem hiding this comment.
it isn't possible to build and use those built types from source.
and it's not worth any more of my time to continue trying to coerce TS into something it's not designed to do.
(already spent too much on this already haha)
NullVoxPopuli
force-pushed
the
nvp/built-in-built-ins
branch
from
c305d15 to
283a423
Compare
NullVoxPopuli
force-pushed
the
nvp/built-in-built-ins
branch
from
283a423 to
4ee3a23
Compare
|
great, this is possibly a prerequisite for making @universal-ember/table, ember-mobile-menu and ember-stargate pure v1-addon-less, as well? |
|
Ye! |
3 participants
When using ember-source 6.8.0-beta.1 or higher, most of the code in this library goes away.
Behavior on earlier ember-source versions is unchanged
Success for this PR will be that: