Preventing /// <reference types="... from showing up in declaration output

[NullVoxPopuli]

Last fix related to this problem here: ember-cli/ember-page-title#283

Not sure what to do, as TypeScript says the behavior (of including references) is correct, so that means we kinda have to work around it.

[ef4]

Can you link me to where they say it's correct?

Have we tested what happens if the addon itself includes a import "ember-source/types" in its own code? Does that make the triple-slash references go away? (That would still not be ideal but would at least be consistent.)

I wonder if tsc is smart enough to not do this if ember-source was using package.json exports to force these files to be private? Surely under those conditions it would be wrong to directly access them from typescript.

[NullVoxPopuli]

Can you link me to where they say it's correct?

Specifically:

• 5.3.2 adds broken "reference" comment microsoft/TypeScript#56571 (comment)
• 5.3.2 adds broken "reference" comment microsoft/TypeScript#56571 (comment)

Have we tested what happens if the addon itself includes a import "ember-source/types" in its own code?

I hadn't, because that would mean min-supported version would have to be [email protected], and imo, not enough people or off 3.28 yet.
But I just tried it on ember-page-title (moving the import "ember-source/types" from unpublished-development-types/index.d.ts to src/index.ts and disabling the part of the inline rollup plugin in that PR to remove the references -- and the /// <reference lines came back -- so I don't think import location makes a difference.

The fix I've implemented is also not ideal, because I don't know what the consequences of .d.ts.map files are -- I've had a hard time verifying .d.ts.map usefulness, and don't have a good way to verify one way or another.

---

For some papertrail / history, her are other occurrences of this problem:

Starting back in August, 2023:

• https://github.com/jmurphyau/ember-truth-helpers/pull/188/files/ce510514b8af75e1dda509162190cced07bf1aee..b21676dacb9585ae4bb63d5e2cf0e9f5cb607d0f#diff-8afe3e4876b5c49d5ffaf6c8f18ae139f02686841982ca9b8ed2020dec8a8cd8
  • uses grep + sed to remove the ///
• Fix triple-slash reference in complied output, breaking TS consumers tracked-tools/ember-async-data#704
  • "resolves" by not depending on certain EmberObject types (which is before TS 5.3, so the probably will likely creep back in if that package releases again)
• Workaround typescript regression in router package embroider#1684
  • "resolves" by pinning to TS ~5.2
• Types are incorrecly published and reference the ember-source built in preview types (which do not exist in sufficiently new enough projects) tildeio/ember-element-helper#111
• Remove reference to EmberComponent to remove the triple-slash directive tildeio/ember-element-helper#113
  • "resolves" by avoiding referring to EmberObject-inheriting things (EmberComponent in this case)
• The latest published build breaks TypeScript apps adopted-ember-addons/ember-file-upload#1035

---

Also (duplicate issue reports)

• Inconsistent tripple-slash directive in sub-directory microsoft/TypeScript#56930