Types are incorrecly published and reference the ember-source built in preview types (which do not exist in sufficiently new enough projects)

[NullVoxPopuli]

I think everything would be fine if just these /// reference lines weren't present:

[types] ../node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected]/node_modules/ember-element-helper/declarations/helpers/element.d.ts:1:23 - error TS2688: Cannot find type definition file for 'ember-source/types/preview/@ember/object/core'.
[types] 
[types] 1 /// <reference types="ember-source/types/preview/@ember/object/core" />
[types]                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[types] 
[types] ../node_modules/.pnpm/[email protected]_@[email protected]_@[email protected][email protected]/node_modules/ember-element-helper/declarations/helpers/element.d.ts:2:23 - error TS2688: Cannot find type definition file for 'ember-source/types/preview/@ember/object/mixin'.
[types] 
[types] 2 /// <reference types="ember-source/types/preview/@ember/object/mixin" />
[types]      

Not really sure why ts or glint would do this, as ember-source is marked as a peerDependency

[gitKrystan]

It's probably this: ember-a11y/ember-a11y-testing#498 (comment)

[NullVoxPopuli]

I'm not so sure

I made an attempt here: #112 but no dice -- /// reference is still present in the declarations output

[SergeAstapov]

@gitKrystan @NullVoxPopuli the strange thing is that https://www.npmjs.com/package/ember-modifier?activeTab=code does not suffer from such issue and no /// reference present in published code

[NullVoxPopuli]

ember-modifier is using rollup-plugin-typescript to generate the type declarations: https://github.com/ember-modifier/ember-modifier/blob/main/ember-modifier/rollup.config.mjs#L28

so perhaps there is some secret its doing that we need to find for folks directly using tsc / glint to generate their declarations

[SergeAstapov]

ember-modifier is using rollup-plugin-typescript to generate the type declarations: https://github.com/ember-modifier/ember-modifier/blob/main/ember-modifier/rollup.config.mjs#L28

I planned to update ember-modifier setup with latest blueprint, will see what the output will be

[NullVoxPopuli]

Made a tool to help out in the future: https://github.com/NullVoxPopuli/fix-bad-declaration-output