Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround typescript regression in router package #1684

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 28, 2023

We're hitting microsoft/TypeScript#56571 such that the router package is emitting a d.ts containing a <reference types that refers to internal private paths in ember-source that are not always valid.

Pinning the typescript version in that package.

@mansona mansona added the bug Something isn't working label Nov 28, 2023
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🎉

@mansona mansona merged commit 5daf70e into main Nov 28, 2023
201 checks passed
@mansona mansona deleted the dev-updates branch November 28, 2023 16:20
@github-actions github-actions bot mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants