Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /// <reference types='ember-sources/types #283

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 22, 2024

These break consumers when they are included in v2 addon output.
(

  • it's the consumer that must provide types for their environment, not any addon
  • also, we can't even be sure that all these paths are going to exist long term
    )

From TS' perspective, this is correct behavior, so this PR uses a tool I made to just remove the references.

image

@HeroicEric
Copy link

HeroicEric commented Jan 22, 2024

Just to be clear, I believe these only cause issues if you're still using the DefinitelyTyped Ember types rather than already using the stable types.

I can confirm that manually deleting the triple-slash directives fixed my issues locally

Copy link
Contributor

@knownasilya knownasilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@HeroicEric
Copy link

Tested with this branch locally and this fixes the issue for me

@NullVoxPopuli NullVoxPopuli merged commit 539cb48 into master Jan 23, 2024
20 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-triple-slash-references branch January 23, 2024 21:37
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Windvis added a commit to Windvis/ember-breadcrumb-trail that referenced this pull request Feb 3, 2024
Windvis added a commit to Windvis/ember-breadcrumb-trail that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants