-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove /// <reference types='ember-sources/types #283
Conversation
Just to be clear, I believe these only cause issues if you're still using the DefinitelyTyped Ember types rather than already using the stable types. I can confirm that manually deleting the triple-slash directives fixed my issues locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Tested with this branch locally and this fixes the issue for me |
dc2c1ac
to
27bced6
Compare
This copies the setup from ember-page-title: ember-cli/ember-page-title#283
This copies the setup from ember-page-title: ember-cli/ember-page-title#283
These break consumers when they are included in v2 addon output.
(
)
From TS' perspective, this is correct behavior, so this PR uses a tool I made to just remove the references.