Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Glint types by converting helpers to plain functions #188

Merged
merged 19 commits into from
Sep 2, 2023
Merged

Fix Glint types by converting helpers to plain functions #188

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7f24e42
Copy contents from https://github.com/jmurphyau/ember-truth-helpers/p…
NullVoxPopuli Aug 28, 2023
ba8ac40
and
NullVoxPopuli Aug 28, 2023
5e30144
eq
NullVoxPopuli Aug 28, 2023
557ff7b
gt
NullVoxPopuli Aug 28, 2023
1c8ba28
gte
NullVoxPopuli Aug 28, 2023
0b89b30
is-array
NullVoxPopuli Aug 28, 2023
19d10cb
is-empty
NullVoxPopuli Aug 28, 2023
f0b46e7
is-equal
NullVoxPopuli Aug 28, 2023
290f72f
lt
NullVoxPopuli Aug 28, 2023
e6314cf
lte
NullVoxPopuli Aug 28, 2023
4b22c67
not-eq
NullVoxPopuli Aug 28, 2023
245e82a
not
NullVoxPopuli Aug 28, 2023
52e9a16
xor
NullVoxPopuli Aug 28, 2023
9f7347f
Add polyfill to support 3.28+
NullVoxPopuli Aug 28, 2023
ce51051
andfix
NullVoxPopuli Aug 29, 2023
b21676d
We no longer need sed to fix /// referenecs
NullVoxPopuli Aug 29, 2023
b8e90e2
make `and` and `or` helpers class based
Aug 31, 2023
7b251ea
add short-circuit tests for `and` and `or` helpers
Sep 2, 2023
9766373
add Glint check for inferred type of `and` and `or` helpers
Sep 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember-truth-helpers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"scripts": {
"build": "concurrently 'npm:build:*'",
"build:js": "rollup --config",
"build:types": "glint --declaration && grep -r -l '///' declarations/ | sort | uniq | xargs perl -e \"s/\\/\\/\\/.*$//\" -pi",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fixed

"build:types": "glint --declaration",
"lint": "concurrently 'npm:lint:*(!fix)' --names 'lint:'",
"lint:fix": "concurrently 'npm:lint:*:fix' --names 'fix:'",
"lint:hbs": "ember-template-lint . --no-error-on-unmatched-pattern",
Expand Down