Refactor Descriptor #14138
Closed
Refactor Descriptor #14138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if (desc instanceof Descriptor) { | ||
| value = desc; | ||
| if (desc === null || desc === undefined) { |
There was a problem hiding this comment.
This branch was just moved up, mostly unchanged. The condition was previously if (desc == null) – note the double equal.
|
does ember correctly strip out the |
|
@stefanpenner it should. |
|
☔ The latest upstream changes (presumably #14319) made this pull request unmergeable. Please resolve the merge conflicts. |
* Duck-type on `isDescriptor === true` instead of using `instanceof` * Require all descriptors to have `setup` and `teardown` * Refactored most descriptors to use ES6 classes except CP descriptors because it’s a big file and I ran out of time for it
locks
force-pushed
the
refactor-descriptor
branch
from
6626300
to
66bb37f
Compare
|
@chancancode just curious do any tests need to be added / changed for this refactor? |
|
☔ The latest upstream changes (presumably #14681) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isDescriptor === trueinstead of usinginstanceofsetupandteardowncc @rwjblue @krisselden @stefanpenner