Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fixes #14298 rendering aliased paths #14319

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Conversation

krisselden
Copy link
Contributor

When dirtying an object, other objects with aliases that path through this object should dirty as well.

When dirtying an object, other objects with aliases
that path through this object should dirty as well.
@chancancode
Copy link
Member

Benchmarks:

It does introduce a small performance cost for initialized but not observed aliases, but overall the impact is pretty small.

@rwjblue rwjblue merged commit 0fdc829 into master Sep 20, 2016
@rwjblue rwjblue deleted the fix-glimmer-alias branch September 20, 2016 03:37
@homu homu mentioned this pull request Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants