Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor descriptor computed #14320

Closed
wants to merge 3 commits into from
Closed

Refactor descriptor computed #14320

wants to merge 3 commits into from

Conversation

locks
Copy link
Contributor

@locks locks commented Sep 20, 2016 •
edited
Loading

Complements #14138.

@chadhietala
Copy link
Contributor

chadhietala commented Sep 20, 2016 •
edited
Loading

I suspect we want to measure this before merging. While I don't think there is going to be perf regression, we need to make sure that the transpiled output in these hot paths dont have an effect.

@locks
Copy link
Contributor Author

locks commented Sep 20, 2016

@chadhietala 👍 how do I do that?

@chadhietala
Copy link
Contributor

Perhaps @chancancode can help / has an opinion.

@homu
Copy link
Contributor

homu commented Nov 8, 2016

☔ The latest upstream changes (presumably 66bb37f) made this pull request unmergeable. Please resolve the merge conflicts.

@locks locks closed this May 18, 2017
@locks locks deleted the refactor-descriptor-computed branch May 18, 2017 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@locks @chadhietala @homu